Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DiceParser #86

Open
Vlek opened this issue May 10, 2022 · 0 comments
Open

Refactor DiceParser #86

Vlek opened this issue May 10, 2022 · 0 comments
Assignees
Labels
refactoring Refactoring
Projects
Milestone

Comments

@Vlek
Copy link
Owner

Vlek commented May 10, 2022

One thing that I have been mulling over is a refactor for the DiceParser
anyway that would allow me to remove a considerable amount of reused
boiler plate code. We have the initial get-left-hand-value and then the
for-loop that then allows us to use the next operation and
left-hand-value, but that means then that we should make functions to
handle those operations and use it inside of a helper method that does
that heavy lifting only in one place.

@Vlek Vlek added the refactoring Refactoring label May 10, 2022
@Vlek Vlek added this to the 3.0 milestone May 10, 2022
@Vlek Vlek self-assigned this May 10, 2022
@Vlek Vlek added this to To do in Roll 3.0 via automation May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
Development

No branches or pull requests

1 participant