Migrate to package references and SDK project format #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycanardeau
changed the title
ycanardeau
commented
Apr 6, 2020
Comment on lines
-1
to
-18
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using FluentNHibernate.Mapping; | ||
| using VocaDb.Model.Domain.Security; | ||
|
|
||
| namespace VocaDb.Model.Mapping.Security { | ||
|
|
||
| public class PermissionTokenMap : ClassMap<PermissionToken> { | ||
|
|
||
| public PermissionTokenMap() { | ||
|
|
||
| Id(m => m.Id); | ||
|
|
||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I removed PermissionTokenMap.cs because it seems that it is not used. In fact, if it is included in the project, a NHibernate.InvalidProxyTypeException will be thrown.
ycanardeau
changed the title
riipah
reviewed
Apr 10, 2020
VocaDbWeb/Web.config
Outdated
| @@ -41,6 +41,8 @@ | |||
| <system.web> | |||
| <compilation debug="true" targetFramework="4.8" batch="false"> | |||
| <assemblies> | |||
| <!-- https://github.com/dotnet/standard/issues/542 --> | |||
| <add assembly="netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" /> | |||
There was a problem hiding this comment.
Did you get the error? I was under the impression this should be unnecessary if AutoGenerateBindingRedirects and PackageReference are enabled.
There was a problem hiding this comment.
You're right. Reverted Web.config.
|
Thank you for your review! |
Merged
|
Thank you for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#550
References:
https://www.michaeltaylorp3.net/migrating-to-sdk-project-format/
https://www.michaeltaylorp3.net/migrating-to-package-references/
dotnet/standard#542