Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/use hypercert api to show reports on homepage #17

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

CJ-Rose
Copy link
Collaborator

@CJ-Rose CJ-Rose commented Jan 30, 2024

No description provided.

Copy link

render bot commented Jan 30, 2024

@@ -0,0 +1,15 @@
// vite.config.ts
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thebeyondr looking into why this file was generated before i remove it..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, it has to be removed anyways because the file paths are specific to your machine lol, no prob!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think i should add it to the .gitignore?
here is discussion about dealing with these files, haven't finished reading yet but doesn't seem to have consensus on the best solution

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think i should add it to the .gitignore? here is discussion about dealing with these files, haven't finished reading yet but doesn't seem to have consensus on the best solution

  • There was something in there about node versioning you could check out?
  • Did you notice it happening after you took a particular action?
  • Maybe uninstall and reinstall dependencies?

Also, we're on that discussion thread now lol

@CJ-Rose
Copy link
Collaborator Author

CJ-Rose commented Jan 30, 2024

i think this can be merged now and then i'll add in the ui updates i've been working on

@thebeyondr
Copy link
Member

@baumstern this removes the /impact-reports route in favor of calling fetchReports directly. Is there any reason you'd prefer a URL pattern or is this ok?

@baumstern
Copy link
Contributor

@baumstern this removes the /impact-reports route in favor of calling fetchReports directly. Is there any reason you'd prefer a URL pattern or is this ok?

It's ok. Actually I think calling fetchReports directly is better than using /impact-reports route

Copy link
Member

@thebeyondr thebeyondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leggo, ty @CJ-Rose! please delete the branch if you're done with it

@thebeyondr thebeyondr merged commit df10bd3 into main Jan 30, 2024
3 checks passed
@CJ-Rose CJ-Rose deleted the feat/homepage-show-reports branch January 30, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants