New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make use of new node features + grammar and punctuation #3

Merged

DanPlayz0 merged 1 commit into Void-Bots:master from splatterxl:patch-1

Mar 8, 2021

Contributor

splatterxl commented Mar 1, 2021

Fixed grammar and punctuation in JSDoc and errors.
A constructor cannot return a value, instead made it throw a string.
Preferred nullish coalescing to the boolean OR operator.
Used optional chaining instead of a long line of &&s.


          feat: make use of new node features

47649bc

* Fixed grammar and punctuation in JSDoc and errors.
* A constructor cannot return a value, instead made it `throw` a string.
* Preferred [nullish coalescing](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator) to the boolean OR operator.
* Used optional chaining instead of a long line of `&&`s.

splatterxl changed the title ~~feat: make use of new node features~~ feat: make use of new node features + grammar and punctuation

DanPlayz0 approved these changes

View reviewed changes

Member

DanPlayz0 left a comment

This pull request does "revoke" backwards compatibility of versions below/behind NodeJS 14.x. Other than that it is all good! 👍

DanPlayz0 merged commit ef1801f into Void-Bots:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet