Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[better_noop] Better Noop Dev Env Handling #7

Merged
merged 2 commits into from
Jan 3, 2021
Merged

Conversation

epociask
Copy link

@epociask epociask commented Jan 3, 2021

Adding interface that's implemented by kstats struct and noop struct to allow for not having to run an environmental conditional check in every aggregation function

Copy link

@adrain-cb adrain-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont see any glaring issues, LGTM

@epociask epociask merged commit 7c7260c into master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants