Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog]: adding subtitle #911

Closed
AyalaBu opened this issue Dec 14, 2022 · 3 comments · Fixed by #934
Closed

[Dialog]: adding subtitle #911

AyalaBu opened this issue Dec 14, 2022 · 3 comments · Fixed by #934
Assignees
@rachelbt @yinonov @AyalaBu
Labels
Enhancement New feature or request Focus: UI UI & design
Milestone
Q.4 22 🕛

Comments

@AyalaBu
Copy link
Contributor

AyalaBu commented Dec 14, 2022

There are a few layout designs for the dialog layout,
a few of them contain a subtitle - it appears here:

https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/Vivid-UI-Kit---3.0-WIP?node-id=19420%3A160156&t=mBYOHp9Om3VmCrkJ-3

I think that this feature is important, and can be needed.
@AyalaBu AyalaBu added Enhancement New feature or request Focus: UI UI & design labels Dec 14, 2022
@rachelbt rachelbt mentioned this issue Jan 3, 2023
Closed
@rachelbt
Copy link
Contributor

rachelbt commented Jan 3, 2023

how long is the subtuitle? is it only one line and if longer it gets ellipsis?
or can it be multiple lines?

@yinonov
Copy link
Contributor

yinonov commented Jan 3, 2023

Start simple. No extra styles

@rachelbt
Copy link
Contributor

rachelbt commented Jan 4, 2023 •
edited
Loading

decided that:

  • text will be changed to subtilte member and will be part of the dialog header (and will be styled as in Figma).
  • content slot will be for dialog body content and will be changed to "body" slot

@rachelbt rachelbt added this to the Q.4 22 🕛 milestone Jan 5, 2023
@rachelbt rachelbt linked a pull request Jan 5, 2023 that will close this issue
fix(dialog): adding subtitle #934
Merged
@github-project-automation github-project-automation bot moved this to Done ✅ in Vivid Roadmap Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachelbt rachelbt

@yinonov yinonov

@AyalaBu AyalaBu

Labels
Enhancement New feature or request Focus: UI UI & design
Projects
Vivid Roadmap
Status: Done ✅
Milestone
Q.4 22 🕛
Development

Successfully merging a pull request may close this issue.

fix(dialog): adding subtitle Vonage/vivid-3
3 participants
@rachelbt @yinonov @AyalaBu