-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #259 from Vonage/not-romaing-bug
Fixing bug with roaming being `not_roaming` and cleaning up some tests
- Loading branch information
Showing
20 changed files
with
521 additions
and
325 deletions.
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
Vonage.Test.Unit/Data/NumberInsightsTests/AdvancedNIRequestSyncWithNotRoamingStatus.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "lookup_outcome": 0, | ||
| "lookup_outcome_message": "Success", | ||
| "request_id": "784758db-0468-4c61-86dc-2dffdb715bac", | ||
| "international_format_number": "971123456789", | ||
| "national_format_number": "053 345 6789", | ||
| "country_code": "AE", | ||
| "country_code_iso3": "ARE", | ||
| "country_name": "United Arab Emirates", | ||
| "country_prefix": "971", | ||
| "request_price": "0.03000000", | ||
| "remaining_balance": "40.27231333", | ||
| "current_carrier": { | ||
| "network_code": "42403", | ||
| "name": "Acme Inc", | ||
| "country": "AE", | ||
| "network_type": "mobile" | ||
| }, | ||
| "original_carrier": { | ||
| "network_code": "42403", | ||
| "name": "Acme Inc", | ||
| "country": "AE", | ||
| "network_type": "mobile" | ||
| }, | ||
| "valid_number": "valid", | ||
| "reachable": "reachable", | ||
| "ported": "not_ported", | ||
| "roaming": { | ||
| "status": "not_roaming" | ||
| }, | ||
| "ip_warnings": "unknown" | ||
| } |
7 changes: 7 additions & 0 deletions
7
Vonage.Test.Unit/Data/NumberInsightsTests/TestAdvancedAsync.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "request_id": "aaaaaaaa-bbbb-cccc-dddd-0123456789ab", | ||
| "number": "447700900000", | ||
| "remaining_balance": "1.23456789", | ||
| "request_price": "0.01500000", | ||
| "status": 0 | ||
| } |
7 changes: 7 additions & 0 deletions
7
Vonage.Test.Unit/Data/NumberInsightsTests/TestAdvancedAsyncAsync.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "request_id": "aaaaaaaa-bbbb-cccc-dddd-0123456789ab", | ||
| "number": "447700900000", | ||
| "remaining_balance": "1.23456789", | ||
| "request_price": "0.01500000", | ||
| "status": 0 | ||
| } |
47 changes: 47 additions & 0 deletions
47
Vonage.Test.Unit/Data/NumberInsightsTests/TestAdvancedNIRequestSync.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "request_id": "aaaaaaaa-bbbb-cccc-dddd-0123456789ab", | ||
| "international_format_number": "447700900000", | ||
| "national_format_number": "07700 900000", | ||
| "country_code": "GB", | ||
| "country_code_iso3": "GBR", | ||
| "country_name": "United Kingdom", | ||
| "country_prefix": "44", | ||
| "request_price": "0.04000000", | ||
| "refund_price": "0.01500000", | ||
| "remaining_balance": "1.23456789", | ||
| "current_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "original_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "ported": "not_ported", | ||
| "roaming": { | ||
| "status": "roaming", | ||
| "roaming_country_code": "US", | ||
| "roaming_network_code": "12345", | ||
| "roaming_network_name": "Acme Inc" | ||
| }, | ||
| "caller_identity": { | ||
| "caller_type": "consumer", | ||
| "caller_name": "John Smith", | ||
| "first_name": "John", | ||
| "last_name": "Smith" | ||
| }, | ||
| "caller_name": "John Smith", | ||
| "last_name": "Smith", | ||
| "first_name": "John", | ||
| "caller_type": "consumer", | ||
| "lookup_outcome": 0, | ||
| "lookup_outcome_message": "Success", | ||
| "valid_number": "valid", | ||
| "reachable": "reachable" | ||
| } |
47 changes: 47 additions & 0 deletions
47
Vonage.Test.Unit/Data/NumberInsightsTests/TestAdvancedNIRequestSyncAsync.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "request_id": "aaaaaaaa-bbbb-cccc-dddd-0123456789ab", | ||
| "international_format_number": "447700900000", | ||
| "national_format_number": "07700 900000", | ||
| "country_code": "GB", | ||
| "country_code_iso3": "GBR", | ||
| "country_name": "United Kingdom", | ||
| "country_prefix": "44", | ||
| "request_price": "0.04000000", | ||
| "refund_price": "0.01500000", | ||
| "remaining_balance": "1.23456789", | ||
| "current_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "original_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "ported": "not_ported", | ||
| "roaming": { | ||
| "status": "roaming", | ||
| "roaming_country_code": "US", | ||
| "roaming_network_code": "12345", | ||
| "roaming_network_name": "Acme Inc" | ||
| }, | ||
| "caller_identity": { | ||
| "caller_type": "consumer", | ||
| "caller_name": "John Smith", | ||
| "first_name": "John", | ||
| "last_name": "Smith" | ||
| }, | ||
| "caller_name": "John Smith", | ||
| "last_name": "Smith", | ||
| "first_name": "John", | ||
| "caller_type": "consumer", | ||
| "lookup_outcome": 0, | ||
| "lookup_outcome_message": "Success", | ||
| "valid_number": "valid", | ||
| "reachable": "reachable" | ||
| } |
42 changes: 42 additions & 0 deletions
42
Vonage.Test.Unit/Data/NumberInsightsTests/TestAdvancedNIRequestSyncWithNullableValues.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "request_id": "aaaaaaaa-bbbb-cccc-dddd-0123456789ab", | ||
| "international_format_number": "447700900000", | ||
| "national_format_number": "07700 900000", | ||
| "country_code": "GB", | ||
| "country_code_iso3": "GBR", | ||
| "country_name": "United Kingdom", | ||
| "country_prefix": "44", | ||
| "request_price": "0.04000000", | ||
| "refund_price": "0.01500000", | ||
| "remaining_balance": "1.23456789", | ||
| "current_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "original_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "ported": null, | ||
| "roaming": null, | ||
| "caller_identity": { | ||
| "caller_type": "consumer", | ||
| "caller_name": "John Smith", | ||
| "first_name": "John", | ||
| "last_name": "Smith" | ||
| }, | ||
| "caller_name": "John Smith", | ||
| "last_name": "Smith", | ||
| "first_name": "John", | ||
| "caller_type": "consumer", | ||
| "lookup_outcome": 0, | ||
| "lookup_outcome_message": "Success", | ||
| "valid_number": "valid", | ||
| "reachable": null | ||
| } |
11 changes: 11 additions & 0 deletions
11
Vonage.Test.Unit/Data/NumberInsightsTests/TestBasicNIRequest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "request_id": "ca4f82b6-73aa-43fe-8c52-874fd9ffffff", | ||
| "international_format_number": "15555551212", | ||
| "national_format_number": "(555) 555-1212", | ||
| "country_code": "US", | ||
| "country_code_iso3": "USA", | ||
| "country_name": "United States of America", | ||
| "country_prefix": "1" | ||
| } |
11 changes: 11 additions & 0 deletions
11
Vonage.Test.Unit/Data/NumberInsightsTests/TestBasicNIRequestAsync.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "request_id": "ca4f82b6-73aa-43fe-8c52-874fd9ffffff", | ||
| "international_format_number": "15555551212", | ||
| "national_format_number": "(555) 555-1212", | ||
| "country_code": "US", | ||
| "country_code_iso3": "USA", | ||
| "country_name": "United States of America", | ||
| "country_prefix": "1" | ||
| } |
4 changes: 4 additions & 0 deletions
4
Vonage.Test.Unit/Data/NumberInsightsTests/TestFailedAdvancedRequest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "status": 4, | ||
| "status_message": "invalid credentials" | ||
| } |
3 changes: 3 additions & 0 deletions
3
Vonage.Test.Unit/Data/NumberInsightsTests/TestFailedAsyncRequest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "status": 4 | ||
| } |
43 changes: 43 additions & 0 deletions
43
Vonage.Test.Unit/Data/NumberInsightsTests/TestStandardNIRequest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "request_id": "aaaaaaaa-bbbb-cccc-dddd-0123456789ab", | ||
| "international_format_number": "447700900000", | ||
| "national_format_number": "07700 900000", | ||
| "country_code": "GB", | ||
| "country_code_iso3": "GBR", | ||
| "country_name": "United Kingdom", | ||
| "country_prefix": "44", | ||
| "request_price": "0.04000000", | ||
| "refund_price": "0.01500000", | ||
| "remaining_balance": "1.23456789", | ||
| "current_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "original_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "ported": "not_ported", | ||
| "roaming": { | ||
| "status": "roaming", | ||
| "roaming_country_code": "US", | ||
| "roaming_network_code": "12345", | ||
| "roaming_network_name": "Acme Inc" | ||
| }, | ||
| "caller_identity": { | ||
| "caller_type": "consumer", | ||
| "caller_name": "John Smith", | ||
| "first_name": "John", | ||
| "last_name": "Smith" | ||
| }, | ||
| "caller_name": "John Smith", | ||
| "last_name": "Smith", | ||
| "first_name": "John", | ||
| "caller_type": "consumer" | ||
| } |
43 changes: 43 additions & 0 deletions
43
Vonage.Test.Unit/Data/NumberInsightsTests/TestStandardNIRequestAsync.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "request_id": "aaaaaaaa-bbbb-cccc-dddd-0123456789ab", | ||
| "international_format_number": "447700900000", | ||
| "national_format_number": "07700 900000", | ||
| "country_code": "GB", | ||
| "country_code_iso3": "GBR", | ||
| "country_name": "United Kingdom", | ||
| "country_prefix": "44", | ||
| "request_price": "0.04000000", | ||
| "refund_price": "0.01500000", | ||
| "remaining_balance": "1.23456789", | ||
| "current_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "original_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "ported": "not_ported", | ||
| "roaming": { | ||
| "status": "roaming", | ||
| "roaming_country_code": "US", | ||
| "roaming_network_code": "12345", | ||
| "roaming_network_name": "Acme Inc" | ||
| }, | ||
| "caller_identity": { | ||
| "caller_type": "consumer", | ||
| "caller_name": "John Smith", | ||
| "first_name": "John", | ||
| "last_name": "Smith" | ||
| }, | ||
| "caller_name": "John Smith", | ||
| "last_name": "Smith", | ||
| "first_name": "John", | ||
| "caller_type": "consumer" | ||
| } |
38 changes: 38 additions & 0 deletions
38
Vonage.Test.Unit/Data/NumberInsightsTests/TestStandardNIRequestWithoutRoaming.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "status": 0, | ||
| "status_message": "Success", | ||
| "request_id": "aaaaaaaa-bbbb-cccc-dddd-0123456789ab", | ||
| "international_format_number": "447700900000", | ||
| "national_format_number": "07700 900000", | ||
| "country_code": "GB", | ||
| "country_code_iso3": "GBR", | ||
| "country_name": "United Kingdom", | ||
| "country_prefix": "44", | ||
| "request_price": "0.04000000", | ||
| "refund_price": "0.01500000", | ||
| "remaining_balance": "1.23456789", | ||
| "current_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "original_carrier": { | ||
| "network_code": "12345", | ||
| "name": "Acme Inc", | ||
| "country": "GB", | ||
| "network_type": "mobile" | ||
| }, | ||
| "ported": "not_ported", | ||
| "roaming": "unknown", | ||
| "caller_identity": { | ||
| "caller_type": "consumer", | ||
| "caller_name": "John Smith", | ||
| "first_name": "John", | ||
| "last_name": "Smith" | ||
| }, | ||
| "caller_name": "John Smith", | ||
| "last_name": "Smith", | ||
| "first_name": "John", | ||
| "caller_type": "consumer" | ||
| } |
Oops, something went wrong.