fix: remove default object for DTMF in MultiInputAction

Vonage · Aug 28, 2024 · f832baf · f832baf
1 parent 8f09ff3
commit f832baf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 24 deletions.
diff --git a/Vonage.Test/Data/MultiInputTests/TestSerializeNccoAllPropertiesEmpty-response.json b/Vonage.Test/Data/MultiInputTests/TestSerializeNccoAllPropertiesEmpty-response.json
@@ -1,12 +1,5 @@
 [
   {
-    "action": "input",
-    "dtmf": {
-    },
-    "speech": {
-      "uuid": [
-        "aaaaaaaa-bbbb-cccc-dddd-0123456789ab"
-      ]
-    }
+    "action": "input"
   }
 ]
diff --git a/Vonage.Test/MultiInputTests.cs b/Vonage.Test/MultiInputTests.cs
@@ -1,8 +1,10 @@
-using Newtonsoft.Json;
+#region
+using Newtonsoft.Json;
 using Vonage.Serialization;
 using Vonage.Voice.EventWebhooks;
 using Vonage.Voice.Nccos;
 using Xunit;
+#endregion
 
 namespace Vonage.Test;
 
@@ -48,11 +50,7 @@ public void TestSerializeNccoAllPropertiesEmpty()
     {
         // arrange
         var expected = this.GetResponseJson();
-        var settings = new SpeechSettings
-        {
-            Uuid = new[] {"aaaaaaaa-bbbb-cccc-dddd-0123456789ab"},
-        };
-        var inputAction = new MultiInputAction {Speech = settings};
+        var inputAction = new MultiInputAction();
 
         //act
         var ncco = new Ncco(inputAction);

diff --git a/Vonage/Voice/Nccos/MultiInputAction.cs b/Vonage/Voice/Nccos/MultiInputAction.cs
@@ -1,6 +1,7 @@
-using System.Collections.Generic;
+#region
+using System.Collections.Generic;
 using Newtonsoft.Json;
-using Newtonsoft.Json.Converters;
+#endregion
 
 namespace Vonage.Voice.Nccos;
 
@@ -21,10 +22,9 @@ public class MultiInputAction : NccoAction
     public string EventMethod { get; set; }
 
     /// <summary>
-    /// DTMF settings. Should be specified to enable DTMF input. If all the DTMF input settings will have default values, it should be specified as empty object
-    /// NOTE: this is serialized as an empty object if not initalized by the user
+    /// DTMF settings. Should be specified to enable DTMF input. 
     /// </summary>
-    [JsonProperty("dtmf", DefaultValueHandling = DefaultValueHandling.Include)]
+    [JsonProperty("dtmf")]
     public DtmfSettings Dtmf { get; set; }
 
     /// <summary>
@@ -39,9 +39,4 @@ public class MultiInputAction : NccoAction
     /// </summary>
     [JsonProperty("speech")]
     public SpeechSettings Speech { get; set; }
-
-    public MultiInputAction()
-    {
-        this.Dtmf = new DtmfSettings();
-    }
 }