Finished GNP Auth and SimSwap MVP implementation #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecondeJK
added a commit
that referenced
this pull request
Jun 24, 2024
* Finished GNP Auth and SimSwap MVP implementation * Add documentation * PSR-4 fix * clean imports * Finished GNP Auth and SimSwap MVP implementation * bring psr7 trait back (#482) * Fix broken git history
SecondeJK
added a commit
that referenced
this pull request
Jun 28, 2024
* Finished GNP Auth and SimSwap MVP implementation * Add documentation * init * Add next workflow to SDK (#476) * Add from validation on request (#477) * Feature/conversations (#478) * WIP * WIP * WIP * WIP * WIP * refactor to remove attempt at putting all event objects in * Added docs * phpstan fix number object * Update README.md 8.1 is minimum * Remove Orphaned Code (#480) * Big cleanup of unused internals * clean some unused imports * Fix baseline, mark some deprecations coming * fix ConversationClientFactory (#479) Co-authored-by: yosh <yosh@latvm.unnamed.typo.pw> * Remove a load of traits not being used by anything (#481) * bring psr7 trait back (#482) * Finished GNP Auth and SimSwap MVP implementation (#475) * Finished GNP Auth and SimSwap MVP implementation * Add documentation * PSR-4 fix * clean imports * Finished GNP Auth and SimSwap MVP implementation * bring psr7 trait back (#482) * Fix broken git history * Bulk of work pre-testing * Testing complete * Configure scopes correctly within the client, remove rogue die statement --------- Co-authored-by: Yoshitaka Takeuchi <yosh@baud.jp> Co-authored-by: yosh <yosh@latvm.unnamed.typo.pw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of features which have been led by the addition of the first Ericsson Global Network Platform API from Vonage - SimSwap.
Description
In order to use SimSwap, a new handler for credentials has been introduced - GnpHandler and a new credentials type, Gnp. These credentials hold the registered subscriber number and extend off the Keypair object.
GNP requires an OAuth flow, which has been implemented within the GnpHandler object. Please note that a lot of this behaviour is for internals only, and should never need to be modified by the end developer.
You can find more information on what the Handler is doing here:
https://developer.vonage.com/en/api/camara/auth
Motivation and Context
Evolution of Vonage SDKs and APIs
How Has This Been Tested?
New test suite added for both GNP handlers and SimSwap
Example Output or Screenshots (if appropriate):
Types of changes
Checklist: