DEVX-7780: Update Logger Type Signatures #290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some Sorbet type signatures for
Logger
creation and assignment. The motivation for this change is that in Rails7.1.0
a change has been made toRails.logger
so that it no longer inherits from Ruby's std libLogger
class. This means thatRails.logger
in7.1.0
is invalid according to the type signatures in the Vonage Ruby SDK. See this issue for more detail.The specific fix is to update the type signatures for logger creation and assignment to conditionally allow Rails 7.1's
ActiveSupport::BroadcastLogger
as a type if it is defined. The signatures updated are:Vonage::Config#logger=
Vonage::Logger#initialize
Thanks to @ohbarye for the detailed bug report and proposed fix.