Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to switch pin from ACPI Mode to GPIO Driver Mode #15

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

1Revenger1
Copy link

Chromebooks leave this register at the default value of zero it seems. I'm not sure if writing to this register ever fails, so I left the check in the return statement.

Could this help out other problematic machines which didn't have the right bits set?

@1Revenger1
Copy link
Author

https://www.intel.com/content/www/us/en/content-details/332691/intel-100-series-chipset-family-platform-controller-hub-pch-datasheet-volume-2.html
I didn't see any restrictions writing to this register while looking at this, but maybe I'm missing something obvious. Is it alright to be writing to this register? If we're using it for an I2C device, I sort of doubt that the firmware/ACPI is using it for something else.

@kprinssu
Copy link
Collaborator

@1Revenger1 Can you tag me on PRs for this repository?
As well as also updating and fixing the conflicts? I will merge the changes in and also create a new release of VoodooI2C.

@1Revenger1
Copy link
Author

@kprinssu Sorry about the delay, was busy the past couple of days.
I just rebased on top of master though, so should be good to go.

@kprinssu
Copy link
Collaborator

Thanks @1Revenger1! I appreciate the PR!

@kprinssu kprinssu merged commit 692f9e4 into VoodooI2C:master Jun 26, 2023
@1Revenger1 1Revenger1 deleted the hostown branch June 26, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants