-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0 Under Bed WAGO Holder #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your mod. Can you please
- rename the STEP file so that it doesn't have a space in the filename
- fix the mentioned spelling errors in your README
- update the top level README in
printer_mods
to add your mod to the list
Checked:
- mod is in the correct directory
- directories names contain no spaces, but one file name does
- mod includes README
- mod does NOT modify top level README
- STL is printable without support
- STL file is not corrupt
- STL file is oriented and scaled properly for printing
Updated the top level README mod list with the requested information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates complete of requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes, PR looks good now.
This mod duplicates the functionality of this mod: #197 Bests, |
I would be happy to integrate it into my repo, as an alternate version, or give my design to @NA411. I don't care about credit. |
I agree it has the same functionality, but it mounts to the bed frame differently. I think merging the two into one repo as alternate versions is a good option |
You'll have to resolve this among yourselves and adjust the PR accordingly. Let me know if I can be of assistance. |
@NA411 if you want to make a pull request on my repo, go for it. don't want to take up any more of these folks time. |
@deepfriedheroin Pull request on your Repo has been submitted. |
Apologies to maintainer for replying here. @NA411 I just noticed this. Will merge, in a few hours. Thank you for the contribution. I, actually, like your design, better than mine. |
Since these changed were added to another repo, can this pull request be closed? |
Yes this can be closed. |
Cleaning up VoronDesign#207 and deepfriedheroin#1. **This is not my work.** All credit goes to NA411. Co-Authored-By: NA411 <5974960+NA411@users.noreply.github.com>
Cleaning up VoronDesign#207 and deepfriedheroin#1. **This is not my work.** All credit goes to NA411. Co-Authored-By: NA411 <5974960+NA411@users.noreply.github.com>
Cleaning up VoronDesign#207 and deepfriedheroin#1. **This is not my work.** All credit goes to NA411. Co-Authored-By: NA411 <5974960+NA411@users.noreply.github.com>
folder. Printable mods go to
printer_mods/
, firmware configurationsgo to
firmware_configurations/
, slicer profiles go toslicer_profiles/
.Create a subfolder with your name, and place the mods in a subfolder with
a descriptive name within that folder, e.g.:
/printer_mods/FHeilmann/flux_capacitor
do not contain any spaces.
README.md
file to its folder with a short descriptionof what the mod accomplishes. This readme can be used to add pictures, give assembly
instructions or specify a bill of materials if the mod requires additional hardware.
README.md
of the category folder adding thecontribution to the table. Read the top part of the file for instructions on how
to do this. Please preserve the alphabetical ordering while adding new rows. Make sure
to fill out the compatibility matrix to indicate which versions of the Voron printer
the submission is compatible with.
and/or other Voron users. Make sure to add information about how the mod was tested below.
or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
which only modifies a few values). (When in doubt, contact one of the admins in the
Voron discord before submitting the PR)
join the Voron discord and ask the other users for advice on how to modify the mod such
that it does not require supports)
and checking if mesh errors are reported.)
Which mods/configurations/profiles are added by this PR?
QUAD 221-412 WAGO Holder
How was it tested?
Printer and installed on two V0s
Any background context you want to provide?
Makes wiring the AC Bed easier and faster/convenient thermal fuse installation or replacement
Screenshots (if appropriate)
Images provided
Further notes
None