Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New result format #2

Closed
VovanR opened this issue Jan 3, 2016 · 3 comments
Closed

New result format #2

VovanR opened this issue Jan 3, 2016 · 3 comments

Comments

@VovanR
Copy link
Owner

VovanR commented Jan 3, 2016

See: https://github.com/bem/bem-tools#options-5
See: https://github.com/bem/bem-tools/blob/support/0.10.x/tests/decl.js

Variant 1

{
  name: 'block',
  mod: {
    name: '',
    val: '',
    sep: ''
  },
  elem: {
    name: 'elem',
    mod: {
      name: 'mod-name',
      val: 'mod-value',
      sep: '_'
    }
  }
}
VovanR added a commit that referenced this issue Jan 3, 2016
VovanR added a commit that referenced this issue Jan 4, 2016
* Update readme
@VovanR
Copy link
Owner Author

VovanR commented Jan 4, 2016

Variant 2

{
  block: {
    name: '',
    mod: {
      name: '',
      val: '',
      sep: ''
    }
  },
  elem: {
    name: '',
    mod: {
      name: '',
      val: '',
      sep: ''
    }
  }
}

@VovanR
Copy link
Owner Author

VovanR commented Jan 4, 2016

Empty props as null?

Input: block_mod
Output:

{
  block: {
    name: 'block',
    mod: {
      name: 'mod',
      val: null,
      sep: '_'
    },
    elem: null
  }
}

Or

{
  block: {
    name: 'block',
    mod: {
      name: 'mod',
      sep: '_'
    }
  }
}

@VovanR VovanR added the question label Jan 4, 2016
@VovanR
Copy link
Owner Author

VovanR commented Jan 4, 2016

Variant 2 is better. Because we can use name to store full className

VovanR added a commit that referenced this issue Jan 4, 2016
* Variant 2
@VovanR VovanR closed this as completed Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant