Some fixes #1
Merged
Some fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armonge
suggested changes
Mar 3, 2017
lib/Voxa-Opearlo.js
Outdated
| (result) => { | ||
| debug(`recordAnalytics (state: ${transition.to}); result: ${result}`); | ||
| resolve(); | ||
| }); | ||
| })); | ||
|
|
||
| skill.onSessionEnded((alexaEvent) => { | ||
| OpearloAnalytics.registerVoiceEvent(alexaEvent.session.user.userId, 'die', 'SessionEndedRequest'); | ||
| alexaEvent.opearloRegistered = true; | ||
| OpearloAnalytics.registerVoiceEvent(alexaEvent.session.user.userId, 'SessionEndedRequest', 'die'); |
There was a problem hiding this comment.
there's no SessionEndedRequest event type according to https://analytics.opearlo.com/setup-analytics/node/alexa-sdk
lib/Voxa-Opearlo.js
Outdated
| @@ -26,27 +26,25 @@ function register(skill, config) { | |||
| skill.onAfterStateChanged((alexaEvent, reply, transition) => { | |||
| OpearloAnalytics.registerVoiceEvent( | |||
| alexaEvent.session.user.userId, | |||
| transition.to, | |||
| 'Custom', | |||
| alexaEvent.intent.name, | |||
There was a problem hiding this comment.
the custom even type should probably be stateTransition or something. Also, not sure if we should be tracking the intent.params for state transition events
armonge
reviewed
Mar 3, 2017
lib/Voxa-Opearlo.js
Outdated
| OpearloAnalytics.registerVoiceEvent( | ||
| alexaEvent.session.user.userId, | ||
| transition.to, | ||
| 'IntentRequest', | ||
| alexaEvent.intent.name, | ||
| alexaEvent.intent.params); |
There was a problem hiding this comment.
if you look at the documentation the third parameter is the intent object, not the intent name
OpearloAnalytics.registerVoiceEvent(event.session.user.userId, "IntentRequest", event.request.intent);
armonge
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.