-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes #1
Some fixes #1
Conversation
lib/Voxa-Opearlo.js
Outdated
(result) => { | ||
debug(`recordAnalytics (state: ${transition.to}); result: ${result}`); | ||
resolve(); | ||
}); | ||
})); | ||
|
||
skill.onSessionEnded((alexaEvent) => { | ||
OpearloAnalytics.registerVoiceEvent(alexaEvent.session.user.userId, 'die', 'SessionEndedRequest'); | ||
alexaEvent.opearloRegistered = true; | ||
OpearloAnalytics.registerVoiceEvent(alexaEvent.session.user.userId, 'SessionEndedRequest', 'die'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no SessionEndedRequest
event type according to https://analytics.opearlo.com/setup-analytics/node/alexa-sdk
lib/Voxa-Opearlo.js
Outdated
@@ -26,27 +26,25 @@ function register(skill, config) { | |||
skill.onAfterStateChanged((alexaEvent, reply, transition) => { | |||
OpearloAnalytics.registerVoiceEvent( | |||
alexaEvent.session.user.userId, | |||
transition.to, | |||
'Custom', | |||
alexaEvent.intent.name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the custom even type should probably be stateTransition
or something. Also, not sure if we should be tracking the intent.params for state transition events
lib/Voxa-Opearlo.js
Outdated
OpearloAnalytics.registerVoiceEvent( | ||
alexaEvent.session.user.userId, | ||
transition.to, | ||
'IntentRequest', | ||
alexaEvent.intent.name, | ||
alexaEvent.intent.params); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you look at the documentation the third parameter is the intent object, not the intent name
OpearloAnalytics.registerVoiceEvent(event.session.user.userId, "IntentRequest", event.request.intent);
No description provided.