Added sample #5
Merged
Added sample #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armonge
reviewed
Mar 3, 2017
| const voxaOpearlo = require('voxa-opearlo'); | ||
|
|
||
| const opearloConfig = { | ||
| userId: 'tkT8PClpPxMOvPbadGyzOoJKwoX2', |
There was a problem hiding this comment.
this shouldn't be here! let's add this to a configuration key and leave it empty with instructions in the readme about it
There was a problem hiding this comment.
Remember this is a public project, we can't expose ANY type of credentials
armonge
suggested changes
Mar 3, 2017
| const voxaOpearlo = require('voxa-opearlo'); | ||
|
|
||
| const opearloConfig = { | ||
| userId: 'tkT8PClpPxMOvPbadGyzOoJKwoX2', |
There was a problem hiding this comment.
Remember this is a public project, we can't expose ANY type of credentials
|
|
||
| return skill.execute(event) | ||
| .then((reply) => { | ||
| expect(reply.toJSON().response.outputSpeech.ssml).to.equal('<speak>Welcome!</speak>'); |
There was a problem hiding this comment.
let's either remove the tests from the sample or update them to actually pass
armonge
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.