hack to append data to a JSON array without doing a read/modify/write #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a pg setup handy to test, but if its works for you then it LGTM. |
|
We have been running this for a while in prod so I will merge it now with the other browserify change. |
jgautier
added a commit
that referenced
this pull request
Jan 20, 2016
hack to append data to a JSON array without doing a read/modify/write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sentientwaffle @anandsuresh @ezray I know this is a gigantic hack but it prevents us from doing a read before modifying the data. This should get rid of about 2 million selects an hour for us hopefully speeding things up. What do you guys think?