Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement User Registration #3

Closed
5 tasks done
W3G33K opened this issue Jul 6, 2020 · 0 comments · Fixed by #4
Closed
5 tasks done

Implement User Registration #3

W3G33K opened this issue Jul 6, 2020 · 0 comments · Fixed by #4
Assignees
@W3G33K
Labels
enhancement New feature or request

Comments

@W3G33K
Copy link
Owner

W3G33K commented Jul 6, 2020 •
edited
Loading

Users should be able to register an account using Knapsack.

  • End-User Dangerous Dave should be able to register an account with Knapsack by providing basic information such as email address, first name, last name, age, username and password.

  • Emails should be unique per end-user.

  • Usernames should be unique per end-user.

  • Validate information provided by user to ensure it's integrity and guarantee user's information is RFS.

  • Hash end-user's password with PHP's build in password_hash function.

References
@W3G33K W3G33K added the enhancement New feature or request label Jul 6, 2020
@W3G33K W3G33K self-assigned this Jul 6, 2020
W3G33K added a commit that referenced this issue Jul 6, 2020
@W3G33K
Task #3 - Implement User Registration
98e67ce 
Added user table migration.
@W3G33K W3G33K linked a pull request Jul 6, 2020 that will close this issue
Task #3 - Implement User Registration #4
Merged
W3G33K added a commit that referenced this issue Jul 6, 2020
@W3G33K
Task #3 - Implement User Registration
ee2e318 
Stubbed out User Controller and User IT TestCase.
W3G33K added a commit that referenced this issue Jul 6, 2020
@W3G33K
Task #3 - Implement User Registration
85d4217 
Stubbed out User Model and User Entity.
W3G33K added a commit that referenced this issue Jul 9, 2020
@W3G33K
Task #3 - Implement filter logic to bind and transform User Data into…
d8c24fb 
… a User Entity.
W3G33K added a commit that referenced this issue Jul 9, 2020
@W3G33K
Task #3 - Implement filter logic to bind and transform User Data into…
609320e 
… a User Entity.
W3G33K added a commit that referenced this issue Jul 9, 2020
@W3G33K
Task #3 - Implement User Registration
2d96e1b 
Renamed User Controller to UserController as the name better indicates what part of the application this class belongs to.
W3G33K added a commit that referenced this issue Jul 9, 2020
@W3G33K
Task #3 - Implement User Registration
c6aea82 
Renamed User Controller to UserController as the name better indicates what part of the application this class belongs to.
W3G33K added a commit that referenced this issue Jul 9, 2020
@W3G33K
Task #3 - Implement User Registration
31694d2 
Updated User entity class to derive standard CI entity functionality from the CI entity class. The functionality from the CI entity class could become very useful.
W3G33K added a commit that referenced this issue Jul 10, 2020
@W3G33K
Task #3 - Implement User Registration
896fb49 
Added route and logic for User Registration.
Disabled CodeIgniter Auto Routing so User Registration route couldn't be accessed via /usercontroller/register URL.
W3G33K added a commit that referenced this issue Jul 10, 2020
@W3G33K
Task #3 - Implement User Registration
7bd6839 
Added route and logic for User Registration.
Disabled CodeIgniter Auto Routing so User Registration route couldn't be accessed via /usercontroller/register URL.
W3G33K added a commit that referenced this issue Jul 10, 2020
@W3G33K
Task #3 - Implement User Registration
4038f48 
Removed call to password_verify here since we shouldn't concern ourselves whether the password can actually be verified or not but whether the BCRYPT algorithm executed successfully or not.
W3G33K added a commit that referenced this issue Jul 11, 2020
@W3G33K
Task #3 - Implement User Registration
3aadca0 
Due to the way CI creates shared instances we must nullify the request in order to prevent test leakage.
W3G33K added a commit that referenced this issue Jul 12, 2020
@W3G33K
Task #3 - Implement User Registration
5affe2d 
Empty password is hashed by UserEntity#setPassword therefore skipping validation checks.
min_length would still happens to be an issue since password becomes 60 characters in length after hashing with bcrypt. I really don't want to hardcode conditions into the setter so I'm trying to figure out a better solution.
W3G33K added a commit that referenced this issue Jul 13, 2020
@W3G33K
Task #3 - Implement User Registration
63f2c31 
Prototyping for clean, elegant, reusable and extendable UI/UX.
W3G33K added a commit that referenced this issue Jul 13, 2020
@W3G33K
Task #3 - Implement User Registration
445d2f2 
Prototyping for clean, elegant, reusable and extendable UI/UX.

Signed-off-by: Ryan K. Clark <mail.w3geek@gmail.com>
W3G33K added a commit that referenced this issue Jul 13, 2020
@W3G33K
Task #3 - Implement User Registration
6ec625a 
Implemented basic validations for User Registration.

Signed-off-by: Ryan K. Clark <mail.w3geek@gmail.com>
W3G33K added a commit that referenced this issue Jul 13, 2020
@W3G33K
Task #3 - Implement User Registration
810c740 
Implemented basic validations for User Registration.

Signed-off-by: Ryan K. Clark <mail.w3geek@gmail.com>
W3G33K added a commit that referenced this issue Jul 14, 2020
@W3G33K
Task #3 - Implement User Registration
3d44411 
Added new timestamps columns (created_at, updated_at and deleted_at) to support CodeIgniter's created, updated and deleted timestamps.

Signed-off-by: Ryan K. Clark <mail.w3geek@gmail.com>
W3G33K added a commit that referenced this issue Jul 14, 2020
@W3G33K
Task #3 - Implement User Registration
727008c 
Passing mocked database to Model when testing against form validation code. Form validation shouldn't concern itself be strictly tested in units only. Analyzing a solution to break this down even more.

Signed-off-by: Ryan K. Clark <mail.w3geek@gmail.com>
W3G33K added a commit that referenced this issue Jul 14, 2020
@W3G33K
Task #3 - Implement User Registration
7eff844 
Fixed minor cosmetic User Registration Form validation issue caused by typo.

Upon load of the User Registration Form Password label would highlight in red because JavaScript thought there was an error with this field.

Signed-off-by: Ryan K. Clark <mail.w3geek@gmail.com>
W3G33K added a commit that referenced this issue Jul 18, 2020
@W3G33K
Task #3 - Implement User Registration
744c551 
Removed validation messages in favor of CodeIgniter's defaults.
W3G33K added a commit that referenced this issue Jul 18, 2020
@W3G33K
Task #3 - Implement User Registration
cb536e6 
Added a new development dependency 'PHP Faker' to generate random user data for UserSeeder.

https://packagist.org/packages/fzaninotto/faker
@W3G33K W3G33K closed this as completed in #4 Jul 18, 2020
W3G33K added a commit that referenced this issue Jul 18, 2020
@W3G33K
Merge pull request #4 from W3G33K/feature/task-3-implement-user-regis…
005c7a8 
…tration

Task #3 - Implement User Registration
@W3G33K W3G33K mentioned this issue Jul 19, 2020
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@W3G33K W3G33K

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Task #3 - Implement User Registration W3G33K/knapsack
1 participant
@W3G33K