Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #39 #52

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Fix issue #39 #52

merged 2 commits into from
Jul 11, 2020

Conversation

jvanstraten
Copy link
Contributor

This should prevent a JS error message when the user's OS is missing the lsb_release CLI tool. The OS description string in the about dialog then becomes "unknown (probably missing lsb_release)". It seemed a bit silly to me to spam a JS error and break the about dialog entirely when a CLI tool that apparently doesn't exist by default on many distros in fact doesn't exist.

Tested only on my local OpenSUSE 15.0 machine, with and without the lsb-release installed.

I'm not a JS developer at all, so let me know if I did something silly, or edit it however. In case it matters (since there doesn't seem to be a CLA), feel free to use, (re)license, or ignore the contents of this PR however you want now or in the future.

@Zzombiee2361
Copy link
Collaborator

I keep forgetting to fix this bug. Can you capitalize the message to "Unknown"?
@cstayyab please merge this and release a new version. I imagine this bug would be pretty annoying to users

@cstayyab cstayyab merged commit 696b23c into WAClient:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants