Fix issue #39 #52
Merged
Fix issue #39 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I keep forgetting to fix this bug. Can you capitalize the message to "Unknown"? |
cstayyab
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent a JS error message when the user's OS is missing the lsb_release CLI tool. The OS description string in the about dialog then becomes "unknown (probably missing lsb_release)". It seemed a bit silly to me to spam a JS error and break the about dialog entirely when a CLI tool that apparently doesn't exist by default on many distros in fact doesn't exist.
Tested only on my local OpenSUSE 15.0 machine, with and without the lsb-release installed.
I'm not a JS developer at all, so let me know if I did something silly, or edit it however. In case it matters (since there doesn't seem to be a CLA), feel free to use, (re)license, or ignore the contents of this PR however you want now or in the future.