Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Source ID - add NorESM2-LM #38

Closed
wants to merge 10 commits into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

This pull request was automatically created by a GitHub Actions workflow.

Data submitted by @IngoBethke

Adding the following new data.

{
    "activity_participation": [
        "CMIP",
        "LESFMIP"
    ],
    "cohort": [
        "unknown"
    ],
    "institution_id": [
        "NCC"
    ],
    "label": "NorESM2-LM",
    "label_extended": "NorESM2-LM (low atmosphere-medium ocean resolution, GHG concentration driven)",
    "license_info": {
        "id": "CC BY 4.0",
        "license": "Creative Commons Attribution 4.0 International",
        "url": "https://creativecommons.org/licenses/by/4.0/",
        "exceptions_contact": "@met.no <- noresm-ncc",
        "history": "2019-08-15: initially published under CC BY-SA 4.0; 2022-06-03: relaxed to CC BY 4.0",
        "source_specific_info": ""
    },
    "model_component": {
        "aerosol": {
            "description": "OsloAero",
            "native_nominal_resolution": "250"
        },
        "atmos": {
            "description": "CAM-OSLO (2 degree resolution; 144 x 96; 32 levels; top level 3 mb)",
            "native_nominal_resolution": "250"
        },
        "atmosChem": {
            "description": "OsloChemSimp",
            "native_nominal_resolution": "250"
        },
        "land": {
            "description": "CLM",
            "native_nominal_resolution": "250"
        },
        "landIce": {
            "description": "CISM",
            "native_nominal_resolution": "250"
        },
        "ocean": {
            "description": "MICOM (1 degree resolution; 360 x 384; 70 levels; top grid cell minimum 0-2.5 m [native model uses hybrid density and generic upper-layer coordinate interpolated to z-level for contributed data])",
            "native_nominal_resolution": "100"
        },
        "ocnBgchem": {
            "description": "HAMOCC",
            "native_nominal_resolution": "100"
        },
        "seaIce": {
            "description": "CICE",
            "native_nominal_resolution": "100"
        }
    },
    "release_year": 2017,
    "source_id": "NorESM2-LM"
}

Copy link
Member

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfiex @IngoBethke some comments for consideration. If getting data written immediately is the priority these could slide

"license": "Creative Commons Attribution 4.0 International",
"url": "https://creativecommons.org/licenses/by/4.0/",
"exceptions_contact": "@met.no <- noresm-ncc",
"history": "2019-08-15: initially published under CC BY-SA 4.0; 2022-06-03: relaxed to CC BY 4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no publication date - sourced from ESGF entries, so this should be blank

CMIP6Plus_source_id.json Show resolved Hide resolved
CMIP6Plus_source_id.json Show resolved Hide resolved
CMIP6Plus_source_id.json Show resolved Hide resolved
CMIP6Plus_source_id.json Show resolved Hide resolved
@IngoBethke
Copy link
Contributor

Thanks for processing the request and for providing feedback.

@wolfiex Should I provide versions for all individual components of NorESM2-LM or only for the "aerosol" component? Can you point me to an example from another model?

In noticed that the HadGEM3 descriptions has "250 km" as value for "native_nominal_resolution". Maybe we should do something similar for NorESM2-LM i.e. add " km" after the value?

@wolfiex
Copy link
Collaborator

wolfiex commented Nov 30, 2023

Thanks for processing the request and for providing feedback.

@wolfiex Should I provide versions for all individual components of NorESM2-LM or only for the "aerosol" component? Can you point me to an example from another model?

In noticed that the HadGEM3 descriptions has "250 km" as value for "native_nominal_resolution". Maybe we should do something similar for NorESM2-LM i.e. add " km" after the value?

If you have all of them, that would be great since (I can then update the table for everyone). This is a new feature so there are no examples as of yet. I expect a version number / release e.g. v3.1.2 or release date/ year will be sufficient in this instance.

Do not worry about the km - that is a decision we shall make make on our end and I can add it if needed.

Submission in the future will follow the steps outlined in https://github.com/WCRP-CMIP/CMIP6Plus_CVs/wiki/Adding-a-new-Source_ID

This is live, and I am using your example as the test case to make sure it is working. :)

Remove CMIP6Plus_CV.json

Automatically generated CV.json: 2023-12-01 01:17

Remove CMIP6Plus_CV.json

Automatically generated CV.json: 2023-12-01 01:17

fix source file
@github-actions github-actions bot force-pushed the source_id_NorESM2-LM branch 2 times, most recently from d357de6 to d81976e Compare December 1, 2023 01:49
@WCRP-CMIP WCRP-CMIP deleted a comment from github-actions bot Dec 1, 2023
Copy link
Contributor Author

github-actions bot commented Dec 1, 2023

This pull request (#38) was automatically updated by a GitHub Actions workflow.

Data submitted by @IngoBethke

Adding the following updated data.

    {
    "activity_participation": [
        "CMIP",
        "LESFMIP"
    ],
    "cohort": [
        "unknown"
    ],
    "institution_id": [
        "NCC"
    ],
    "label": "NorESM2-LM",
    "label_extended": "NorESM2-LM (low atmosphere-medium ocean resolution, GHG concentration driven)",
    "license_info": {
        "id": "CC BY 4.0",
        "license": "Creative Commons Attribution 4.0 International",
        "url": "https://creativecommons.org/licenses/by/4.0/",
        "exceptions_contact": "@met.no <- noresm-ncc",
        "source_specific_info": ""
    },
    "model_component": {
        "aerosol": {
            "description": "OsloAero",
            "version": "none",
            "native_nominal_resolution": "250"
        },
        "atmos": {
            "description": "CAM-OSLO (2 degree resolution; 144 x 96; 32 levels; top level 3 mb)",
            "version": "none",
            "native_nominal_resolution": "250"
        },
        "atmosChem": {
            "description": "OsloChemSimp",
            "version": "none",
            "native_nominal_resolution": "250"
        },
        "land": {
            "description": "CLM",
            "version": "none",
            "native_nominal_resolution": "250"
        },
        "landIce": {
            "description": "CISM",
            "version": "none",
            "native_nominal_resolution": "250"
        },
        "ocean": {
            "description": "MICOM (1 degree resolution; 360 x 384; 70 levels; top grid cell minimum 0-2.5 m [native model uses hybrid density and generic upper-layer coordinate interpolated to z-level for contributed data])",
            "version": "none",
            "native_nominal_resolution": "100"
        },
        "ocnBgchem": {
            "description": "HAMOCC",
            "version": "none",
            "native_nominal_resolution": "100"
        },
        "seaIce": {
            "description": "CICE",
            "version": "none",
            "native_nominal_resolution": "100"
        }
    },
    "release_year": 2017,
    "source_id": "NorESM2-LM"
}

@wolfiex wolfiex closed this Jan 28, 2024
@wolfiex wolfiex deleted the source_id_NorESM2-LM branch January 28, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source_id: request to add NorESM2-LM
3 participants