Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent equipment window scrolling on change #221

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

tboby
Copy link
Contributor

@tboby tboby commented Jan 15, 2022

What did you fix? (provide a description or issue closes statement)

Currently, when you add, remove, or master items on the equipment window it refreshes the treeview which often causes everything to scroll randomly.

This fix prevents the whole treeview from refreshing. Counts seem to update fine without it.

If you're in "Owned" or related sort modes, it doesn't automatically resort, but that would probably be annoying (and doesn't appear to happen in current master anyway)


Reproduction steps

  1. Open equipment view
  2. Open all four top categories
  3. Open an item in each category
  4. Scroll halfway down, then add one to an item
  5. The treeview scrolls as the Warframe category closes and reopens

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Is is a bug fix, feature request, or enhancement? Bug Fix

@PeterJeff
Copy link
Contributor

In my testing this did stop the weird scrolling problems when increasing inventory counts.

Is there a reason these lines existed in the first place?

@dimon222
Copy link
Member

I think something to do with DPI scaling, but as long as it works I'm okay. Merging in.

@dimon222 dimon222 merged commit 58375dc into WFCD:master Jan 21, 2022
@dapal-003
Copy link
Contributor

In my testing this did stop the weird scrolling problems when increasing inventory counts.

Is there a reason these lines existed in the first place?

I believe it's an artifact from previous UI where it was required, it would hide the entire list and the refresh populated it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants