Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📣 Featured Exhibits #143

Merged
merged 3 commits into from
Dec 20, 2023
Merged

📣 Featured Exhibits #143

merged 3 commits into from
Dec 20, 2023

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Dec 18, 2023 •
edited
Loading

Exhibits

  • Adds featured boolean to model
  • Uses index.AutoCompleteField to use partial matching on exhibit body

Closes #123
Closes #58

@mrharpo mrharpo added the enhancement ➕ New feature or request label Dec 18, 2023
@mrharpo mrharpo added this to the v0.y.0 Beta 🌁 milestone Dec 18, 2023
@mrharpo mrharpo self-assigned this Dec 18, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (890d7fc) 91.09% compared to head (6d08649) 91.14%.

Files Patch % Lines
exhibits/api.py 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   91.09%   91.14%   +0.04%     
==========================================
  Files          46       48       +2     
  Lines         528      542      +14     
==========================================
+ Hits          481      494      +13     
- Misses         47       48       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrharpo mrharpo marked this pull request as ready for review December 18, 2023 23:52
@mrharpo mrharpo requested a review from afred December 18, 2023 23:52
@mrharpo mrharpo merged commit ebc4039 into main Dec 20, 2023
10 checks passed
@mrharpo mrharpo deleted the 123-featured branch December 20, 2023 18:26
mrharpo added a commit that referenced this pull request Dec 20, 2023
@mrharpo
Merge branch 'main' into elastic
c8447a9 
* main:
  🤖 Update dependencies (#145)
  📣 Featured Exhibits (#143)
  🥣 `other_exhibits` serializer (#141)
  📗 Backend Docs (#131)
  🤖 Update dependencies (#133)
  🪓 Fixes Auth0 login (#140)
  💿 AAPB records (#138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred Awaiting requested review from afred

Assignees

@mrharpo mrharpo

Labels
enhancement ➕ New feature or request
Projects
OpenVault - Fall 2023
Status: ✅ Done
Milestone
v0.5.0 Beta 🌁
1 participant
@mrharpo