Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage information #1

Open
kaichop opened this issue Apr 16, 2019 · 4 comments
Open

usage information #1

kaichop opened this issue Apr 16, 2019 · 4 comments

Comments

@kaichop
Copy link
Contributor

kaichop commented Apr 16, 2019

There is no description of input, output and example usage information. There is no description what this tool actually does, and what this particular script does, and how it can be used to call variants given a BAM file.

@umahsn
Copy link
Collaborator

umahsn commented Apr 22, 2019

I have added some information.

@umahsn
Copy link
Collaborator

umahsn commented May 6, 2019

I have updated the usage docs.

@WGLab WGLab deleted a comment from umahsn May 29, 2020
@danrdanny
Copy link

Hi, thanks for making this tool available. I'd like to try it, but I'm having trouble understanding some of the options and getting it to run.

First, regarding indel mode. In your preprint you say:

"We use WhatsHap to phase variants, allowing the algorithm to re-genotype variants. In the phasing step, all variant calls made by NanoCaller, both in high-confidence regions and outside confidence regions are used. Any candidate site whose genotype changes to homozygous reference is considered as non-variantcall. Afterwards, we use WhatsHap again to phase alignment reads in order to create pileup images for indels."

But, in the usage information you say the bam file must be phased if indel mode is chosen.

The description in the preprint makes me think NanoCaller does the phasing, but the usage information suggests I have to do it. Can you clarify?

Second, it appears I can pass a bed file to NanoCaller. Can you describe what this is doing? Does it override -chrom?

Finally, can you provide an example dataset for running this program so I can make sure I'm using it correctly?

Thanks!

@umahsn
Copy link
Collaborator

umahsn commented Jul 23, 2020

The default NanoCaller workflow, which is the mode 'both', goes like this:

bam file > SNP calling by NanoCaller > SNP phasing by whatshap > Reads phasing by whatshap > Indel calling by NanoCaller on reads phased in previous step > Combine indel and SNP calls

If you choose 'indel' mode, then we do not have any SNPs that we can use to phase the reads in order to call indels. This option is allowed so that if a user prefers to use a different tool than whatshap to carry out SNPs and reads phasing, or if they already have phased reads that they believe are phased using some other reliable method, then they can bypass the whatshap subroutine by NanoCaller and supply their own phased bam file.

Another reason for this option is that if a user runs NanoCaller in 'both' mode, but the program crashes during indel calling stage for some likely scenarios such as memory exceeding system limits, then they can resume NanoCaller at the indel calling stage, instead of having to do the entire SNP calling and phasing all over again.

We have removed the option for bed files for now. We found for whole genome variant calling that using a bed file would get rid of potential variants near the boundaries of the interval in a bed file. So we found it better to leave it up to a user to filter variants with a bed file using a more sophisticated tool like rtg vcffilter. But I can see having an option like bed file can be useful if you you dont want to spend extra time in calling variants that are outside the intervals in a bed file, and submitting individual calls for each line in a bed file can be cumbersome. We will revisit this issue in our team. Do you have any preferences or thoughts about this?

We provide an example here: https://github.com/WGLab/NanoCaller/tree/master/sample
You can see the command we used in the file: https://github.com/WGLab/NanoCaller/blob/master/sample/sample_call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants