Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 3DLoMatch test trigger #19

Merged
merged 1 commit into from
May 31, 2024
Merged

fix 3DLoMatch test trigger #19

merged 1 commit into from
May 31, 2024

Conversation

Shi-Qi-Li
Copy link
Contributor

Hi @HpWang-whu,
Thanks for open source the code. But there may be a small bug in Test_cycle.py

SGHR/Test_cycle.py

Lines 210 to 213 in fdfb081

def run(self):
self.run_onedatasets(self.datasets)
if self.datasets['wholesetname'] is '3dmatch':
self.run_onedatasets_givengraph(self.datasetsLo)

Here is is used to trigger the 3DLoMatch test, however is checks for identity - if the two variables point to the exact same object. Since self.datasets['wholesetname'] and 3dmatch are different objects, the 3DLoMatch test will not executed. Simply use == to replace is will fix this issue.

@HpWang-whu
Copy link
Collaborator

Thanks for pointing out the error!

@HpWang-whu HpWang-whu merged commit e0dc1c2 into WHU-USI3DV:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants