Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @HpWang-whu,
Thanks for open source the code. But there may be a small bug in
Test_cycle.py
SGHR/Test_cycle.py
Lines 210 to 213 in fdfb081
Here
is
is used to trigger the 3DLoMatch test, howeveris
checks for identity - if the two variables point to the exact same object. Sinceself.datasets['wholesetname']
and3dmatch
are different objects, the 3DLoMatch test will not executed. Simply use==
to replaceis
will fix this issue.