Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export CrashReportBody to reffy #8

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

stephenmcgruer
Copy link
Contributor

User agents are not expected to implement CrashReportBody, since the
report cannot ever be received in JavaScript (because the browser has
crashed!). As such, there is no reason to export this to reffy and try
to test it in WPT, see
web-platform-tests/wpt#24190

User agents are not expected to implement CrashReportBody, since the
report cannot ever be received in JavaScript (because the browser has
crashed!). As such, there is no reason to export this to reffy and try
to test it in WPT, see
web-platform-tests/wpt#24190
@stephenmcgruer
Copy link
Contributor Author

@foolip - can you confirm if this is correct?

@clelland - I wasn't sure about re-generating the HTML here; I tried using hosted bikeshed but it seemed to update a bunch of lines, is that expected?

@clelland
Copy link
Collaborator

The regenerated HTML looks good; possibly just a more recent version of bikeshed than the one that the previous version was built with. Besides the slight differences to the styling, the differences I see are:

  • new date
  • exclude added to the appropriate nodes
  • Updated section links to the Reporting spec, which are correct
  • Some removed ids, which seem okay.

@foolip
Copy link
Member

foolip commented Jul 1, 2020

@stephenmcgruer yes, this should do the trick.

@clelland clelland merged commit d3a52a0 into WICG:gh-pages Jul 2, 2020
@clelland
Copy link
Collaborator

clelland commented Jul 2, 2020

Thanks, @foolip -- merging this.

@tidoust
Copy link

tidoust commented Jul 18, 2020

I believe that the right way to exclude IDL in Bikeshed is rather to use an extract class (and not export), see:
speced/bikeshed#946
https://tabatkins.github.io/bikeshed/#no-idl

As things stand, the IDL still appears in the IDL index at the end of the spec, which Reffy uses in Bikeshed specs.

(The use of extract may not be perfect in any case, as these classes are more meant to exclude IDL that is just an example than to document IDL that is not meant to be exposed to browsers, but then I don't think that there exists a mechanism to flag the latter)

@clelland
Copy link
Collaborator

Hmm... not sure anymore if we're holding this thing right. @tabatkins, can you provide any guidance here?

@foolip
Copy link
Member

foolip commented Jul 18, 2020

Oh, so Reffy uses Bikeshed's IDL index and so we need to use the class that Bikeshed cares about, extract. Reffy also excludes things with exclude, but that doesn't matter... Oops, sorry for giving the wrong suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants