Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic beacon patches #109

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Add automatic beacon patches #109

merged 6 commits into from
Aug 16, 2023

Conversation

blu25
Copy link
Collaborator

@blu25 blu25 commented Aug 2, 2023 •
edited by pr-preview bot
Loading

  • Adds "attempt to send an automatic beacon" algorithm
  • Adds patch to "attempt to populate the history entry's document" to invoke "attempt to send an automatic beacon".
  • Adds "once" parameter to the FenceEvent dictionary and automatic beacon data struct.

Preview | Diff

domfarolino
domfarolino reviewed Aug 16, 2023
View reviewed changes
spec.bs Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
domfarolino
domfarolino approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@domfarolino domfarolino merged commit 7281202 into master Aug 16, 2023
1 check passed
@domfarolino domfarolino deleted the liam-automatic-beacon branch August 16, 2023 21:46
github-actions bot added a commit that referenced this pull request Aug 16, 2023
@blu25 @github-actions
Add automatic beacon patches (#109)
635d406 
SHA: 7281202
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@shivanigithub shivanigithub mentioned this pull request Aug 25, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domfarolino domfarolino domfarolino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blu25 @domfarolino