Require a "." to be included in the accepted extensions. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 18, 2020
Implements the changes from WICG/file-system-access#219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b
This is more in line with how accepts in input type=file works, as well as how the file handling API currently is specified. Fixes #213
mkruisselbrink
force-pushed
the
period-for-extensions
branch
from
931a0f7
to
996cb57
Compare
inexorabletash
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Normative changes LGTM, with the issue noted. Can fix here or a follow up.
Non-normative text still refers to "extensions" and should be updated carefully in a subsequent PR, e.g. saying something like suffixes (commonly called "extensions") somewhere. The domintro section should also call out that the leading . is required.
I did add a mention of "." being required. Not sure about rephrasing the non-normative text to say suffixes. HTML just calls these things extensions in its description of |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 19, 2020
Implements the changes from WICG/file-system-access#219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799617}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Aug 19, 2020
Implements the changes from WICG/file-system-access#219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799617}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 19, 2020
Implements the changes from WICG/file-system-access#219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799617}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 25, 2020
…ensions., a=testonly Automatic update from web-platform-tests [FS] Require a leading . in accepted extensions. Implements the changes from WICG/file-system-access#219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799617} -- wpt-commits: 7a3831fa57581bcd6081f9a2d2befbda888c016b wpt-pr: 25071
ambroff
pushed a commit
to ambroff/gecko
that referenced
this pull request
Nov 4, 2020
…ensions., a=testonly Automatic update from web-platform-tests [FS] Require a leading . in accepted extensions. Implements the changes from WICG/file-system-access#219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799617} -- wpt-commits: 7a3831fa57581bcd6081f9a2d2befbda888c016b wpt-pr: 25071
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Implements the changes from WICG/file-system-access#219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799617} GitOrigin-RevId: 79011db8c74b84c315a098ed89896255142baf2c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more in line with how accepts in input type=file works, as well
as how the file handling API currently is specified.
Fixes #213
Preview | Diff