Make wicg-inert work properly with strict CSP by allowing external stylesheet #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ylesheet wicg-inert currently relies on inserting an inline CSS stylesheet, which is not possible with a Content Security Policy that does not include `unsafe-inline` for the `style-src` directive. This patch allows providing an external stylesheet with the content that wicg-inert would dynamically insert.
|
This seems like a good change. Would you mind adding a note in the README explaining how to use this feature? |
robdodson
approved these changes
May 13, 2020
|
Done! |
robdodson
approved these changes
May 13, 2020
|
nice, thank you! I have another PR in the works that I'd like to land and then I can push out a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wicg-inert currently relies on inserting an inline CSS stylesheet, which is
not possible with a Content Security Policy that does not include
unsafe-inlinefor thestyle-srcdirective.This patch allows providing an external stylesheet with the content that
wicg-inert would dynamically insert.