Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit: FontMetadata contains more than metadata #49

Closed
jakearchibald opened this issue Oct 8, 2020 · 1 comment
Closed

Nit: FontMetadata contains more than metadata #49

jakearchibald opened this issue Oct 8, 2020 · 1 comment
Assignees
@inexorabletash
Labels
api-shape Would affect the API shape (IDL)
Milestone
MVP

Comments

@jakearchibald
Copy link

It also has .blob() which gives you the full file. Should this be FontData?
@jakearchibald jakearchibald mentioned this issue Oct 8, 2020
Open
@inexorabletash inexorabletash added the api-shape Would affect the API shape (IDL) label Apr 30, 2021
@inexorabletash
Copy link
Member

Yeah, we should probably change this.

@inexorabletash inexorabletash added this to the MVP milestone Mar 28, 2022
inexorabletash added a commit that referenced this issue Mar 28, 2022
@inexorabletash
Rename FontMetadata to just FontData. Fixes #49
62e1d81
@inexorabletash inexorabletash self-assigned this Mar 28, 2022
github-actions bot added a commit that referenced this issue Mar 29, 2022
@inexorabletash @github-actions
Rename FontMetadata to just FontData. Fixes #49 (#77)
49d611c 
SHA: 09bc77c
Reason: push, by @inexorabletash

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inexorabletash inexorabletash

Labels
api-shape Would affect the API shape (IDL)
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
2 participants
@jakearchibald @inexorabletash