Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest 'unknown' connection type instead of 'other' #11

Closed
jkarlin opened this issue Jun 5, 2014 · 5 comments
Closed

Suggest 'unknown' connection type instead of 'other' #11

jkarlin opened this issue Jun 5, 2014 · 5 comments

Comments

@jkarlin
Copy link

jkarlin commented Jun 5, 2014

There are times where it's difficult for the UA to determine what the connection type is. What should be the connection type in those cases? Unknown is more accurate than other.

@marcoscaceres
Copy link
Contributor

Agree, 'unknown' makes sense there. Just to be clear, we probably just need to come up with a good definition for how it differs form "none" and "other". I.e., the connection is established, but the type can't be determined.

@marcoscaceres
Copy link
Contributor

@jkarlin if you have a concrete situation where this comes up, that would be really helpful.

@jkarlin
Copy link
Author

jkarlin commented Jun 5, 2014

It's probably possible to get all of these types on all of the platforms that browsers run on, but there are several cases in Chromium (e.g., desktop) where bluetooth and cellular are not distinguished. We may fill them all out eventually but it will take time.

@marcoscaceres
Copy link
Contributor

@jkarlin for your review: https://github.com/w3c/netinfo/pull/12

I've kept other, because it's slightly different: it means "connection type is known, but it's not in the list of enums". Hope that works for you.

@jkarlin
Copy link
Author

jkarlin commented Jun 6, 2014

Perfect, thank you.

@jkarlin jkarlin closed this as completed Jun 6, 2014
marcoscaceres added a commit that referenced this issue Jun 6, 2014
Added `unknown` connection type (closes #11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants