-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid adding a new directive to CSP #88
Comments
It would be best to determine the compatibility impact of such a change. Do many sandboxed iframes need access to the private network? They would lose it as part of this change unless they added the new flag. |
This model seems pretty reasonable to me if it's borne out by usage numbers. Independent from tests, I think it's good to give pages a way to drop their network-positional privilege. I'd simply like to do so without further muddying the waters around what CSP does. |
Well, CSP does do sandboxing. 😊 |
Yup. And if sandboxing grows some new functionality, CSP should pass it through so we can tell a consistent story about top-level sandboxing! That said, I don't think we'd put |
@mikewest tells me that he wished not to add a new directive to CSP in the form of
treat-as-public-address
. crbug.com/1000226 has been languishing in obscurity for Chromium.Since this is a useful primitive for tests in particular, I'd like to keep it in some form. In fact, I believe we can solve two issues at once by spelling this as a sandbox flag.
If we define a new sandbox flag that grants access to the private network (provided PNA checks succeed), then we can also solve #26.
For iframes:
For top-level documents, CSP would still be used to deliver the flag, but we would avoid adding a new directive.
The text was updated successfully, but these errors were encountered: