-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@rule for nav-loop? #4
Comments
Yes, I also prefer to specify focus looping with at-rule, and a descriptor something like |
As discussed in issue #3, enabling spat-nav on a component basis, rather than page basis, seems to make sense. In that case, this should probably be possible to enable/disable with the same granularity. That said, Like issue #1, I think we should postpone this until we get the APIs discussed in issue #2 so that we can try to polyfill and/or experiment with this first. |
I think this feature, the focus looping doesn't have to be supported by CSS. |
I agree, at least for a first pass. If people use it all the time, maybe we can introduce an declarative API for it later on. |
We don't need so many issues about nav-loop. |
Add test cases for the distance function experiment
It is not entirely clear to me that having different values of
nav-loop
on different parts of the page is useful. If there are indeed use cases that would benefit from it, the then current design (modulo issue #1 ) is fine, but if not, it introduces unnecessary complexity.It also seems like an easy way to accidentally create designs that would frustrate users: if a DOM sub-tree has
nav-loop: repeat
, but there are focusable elements outside of that subtree, the users will not be able to get there. The same thing can already happen with poor usage ofnav-up
/nav-down
/nav-right
/nav-left
, but doing so accidentaly seems more likely withnav-loop
as a property.This would solve the key use case, without having that downside:
Alternatively, if we end up with other spat-nav related things that belong in at-rules, we could have:
Unless someone has use cases that call for the property, I'd suggest keeping it simple and using an at-rule.
The text was updated successfully, but these errors were encountered: