-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update real time reporting explainer. #1226
Conversation
| 2 | Trusted bidding signals fetch error | | ||
| 3 | Trusted scoring signals fetch error | | ||
|
||
Fetch errors include non-2xx response code, response header does not have “Ad-Auction-Allowed: true”, response body cannot be parsed as valid json for trusted signals, etc,. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A 304 (Not Modified) would be considered an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. Non-2xx codes will be considered as errors.
See step 2 of spec: https://wicg.github.io/turtledove/#validate-fetching-response-headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bidding and scoring scripts (versus the dynamic signals) are expected to be slowly changing and adtechs will count on browsers' HTTP cache.
Not modified (304) is not an error status:
A null body status is a [status](https://fetch.spec.whatwg.org/#concept-status) that is 101, 103, 204, 205, or 304.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the code that checks for the header to be 2xx.
@morlovich knows the network related code better. @morlovich would you mind helping here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you normally won't see a 304 at this layer, but rather the cached response (with updated headers).
Probably this stuff:
https://fetch.spec.whatwg.org/#:~:text=If%20the%20revalidatingFlag%20is%20set%20and%20forwardResponse%E2%80%99s%20status%20is%20304%2C%20then%3A
Co-authored-by: Paul Jensen <JensenPaul@users.noreply.github.com>
SHA: 1cd0495 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There are 4 main updates we’re making to the explainer: