-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clearOriginJoinedAdInterestGroups() #829
Merged
JensenPaul
merged 4 commits into
WICG:main
from
MattMenke2:clearOriginJoinedAdInterestGroups
Oct 20, 2023
Merged
Add clearOriginJoinedAdInterestGroups() #829
JensenPaul
merged 4 commits into
WICG:main
from
MattMenke2:clearOriginJoinedAdInterestGroups
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed API to make managing interest groups on a per-joining-top-level-origin basis easier.
JensenPaul
added
the
Non-breaking Feature Request
Feature request for functionality unlikely to break backwards compatibility
label
Sep 25, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 29, 2023
See WICG/turtledove#829 for description of the method. It's intended to let Private Audience / FLEDGE interest groups be more easily managed on a per-top-level-origin basis. Bug: 1486606 Change-Id: Id75fd7f8aa515366b9257f94be58a3822d08bfd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4886584 Reviewed-by: Russ Hamilton <behamilton@google.com> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#1203420}
JensenPaul
reviewed
Oct 3, 2023
JensenPaul
reviewed
Oct 3, 2023
Co-authored-by: Paul Jensen <JensenPaul@users.noreply.github.com>
Co-authored-by: Paul Jensen <JensenPaul@users.noreply.github.com>
Both suggestions look good, thanks Paul! |
JensenPaul
approved these changes
Oct 9, 2023
Paul: Think you need to land it, too? "Only those with write access to this repository can merge pull requests." |
github-actions bot
added a commit
that referenced
this pull request
Oct 20, 2023
SHA: c063b7f Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JensenPaul
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Add clearOriginJoinedAdInterestGroup to spec.bs This adds the explainer changes from explainer PR #829 / issue #475 to the spec. * Update spec.bs Some cleanups - more likely to follow. * Update spec.bs * Update spec.bs * Update spec.bs Fix error? * Update spec.bs * Update spec.bs * Update spec.bs * Update spec.bs * Update spec.bs * Update spec.bs * Update spec.bs * Update spec.bs * Update spec.bs * Update spec.bs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Non-breaking Feature Request
Feature request for functionality unlikely to break backwards compatibility
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed API to make managing interest groups on a per-joining-top-level-origin basis easier. See issue #475 for the motivating proposal.