Add launch_handler explainer #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgiuca
approved these changes
Jul 23, 2021
| }; | ||
|
|
||
| partial interface Window { | ||
| readonly attribute LaunchQueue launchQueue; |
There was a problem hiding this comment.
I'd be cautious about adding things to the Window object. I don't have a better suggestion of where to put it, but doing this can be risky because it can clash with userland code.
There was a problem hiding this comment.
I think the main risk is if code does something like this:
launch_queue.js:
if (!window.launchQueue)
window.launchQueue = new SomeLaunchQueueClass();
main.js:
window.launchQueue.someMethod(someParam);
index.html:
<script src="launch_queue.js"></script>
<script src="main.js"></script>
Do you know of any other code patterns that would break?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created explainer from discussion: #33
View rendered markdown: https://github.com/alancutter/sw-launch/blob/launch_handler/launch_handler.md
Moved from manifest-incubations pull request: WICG/manifest-incubations#14