-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Scripts With FC REST Updates #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Out of scope for this PR, but I wonder since we're (re)using the logical_name + query construct, if we should add a query shortcut inside the FC to mean this?
It's a good idea since we're making it a construct here. But I'm hesitant to introduce more abstraction to the query interface considering we've departed the " |
Note: I'm not sure if we'll ever get this version of the FC to index |
closes #31