Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powercurve points #101

Merged
merged 11 commits into from
Apr 23, 2021
Merged

Powercurve points #101

merged 11 commits into from
Apr 23, 2021

Conversation

ewquon
Copy link
Contributor

@ewquon ewquon commented Apr 9, 2021

Purpose

All changes made with help from @nikhar-abbas!

  1. Fix issue with pitch saturation schedule being improperly calculated -- required update to latest in ROSCO Toolbox develop branch and changing the definition of V_rated
  2. Fix issue with MPI ranks when there are no design variables, e.g., for running a power curve sweep in parallel. Previously, N outputs/rank_* directories would be created, with the full sweep being run sequentially in each processor directory. After fix, running with N_pc+1 processors results in a single outputs/rank_0 directory with simulations at all wind speeds proceeding in parallel (@ptrbortolotti, see be0d175)

Example results shown below with WISDEM design as solid lines, OpenFAST results by WEIS as markers.

Before:
Before RT-develop and V_rated update

After:
MPI results, after pitch saturation schedule fix

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

New PC sweep matches results from previous version of WEIS (f/thrust_shaving_gb branch)

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewquon
Update to latest ROSCO Toolbox develop
9605644 
Merge commit '198964d3ee1b6afc9d04e76a1446d02964e3a4ea' into powercurve_points
@ewquon
Squashed 'ROSCO_toolbox/' changes from 9b123f1..381ae28
198964d 
381ae28 CI Testing (WISDEM#41)
da6b56c Merge pull request WISDEM#40 from nikhar-abbas/b/interp
67d5d36 Write example_07 (min pitch) output to new figure
3750beb Remove double instance of rated wind speed in controller.v
9e89ef8 Make interpolation function monotonic
65c4020 linear interpolation
53343d1 Delete history file
07b46b6 Update version to 2.2.0
REVERT: 9b123f1 Update examples to test in weis environment, working
REVERT: 15976f5 Merge branch 'develop' into weis
REVERT: 7d28a6f Get rid of annoying spectral warning
REVERT: 25ef7a7 Update ROSCO install dir, other setup fun stuff
REVERT: 52465fe Merge remote-tracking branch 'upstream/develop' into weis
REVERT: 3454fc0 Merge remote-tracking branch 'upstream/develop' into weis
REVERT: b730428 Merge pull request WISDEM#28 from nikhar-abbas/weis
REVERT: 71565e1 Revert "fix minpitch saturation bug"
REVERT: 34b427c Update submodule to track develop branch
REVERT: f504b34 remove 0.7 from flpwise damping conversion
REVERT: bc8c9c3 write kappa to self
REVERT: 38e956e Merge branch 'weis' of https://github.com/NREL/ROSCO_toolbox into weis
REVERT: 096f1e9 Merge branch 'develop' into weis
REVERT: cf5b43b Fix another ofTools import
REVERT: 67731f8 Fix ofTools import
REVERT: 2256b0c Move ofTools into ROSCO_toolbox
REVERT: e4a1c7f Revert setup.py to exclude ROSCO build, etc.
REVERT: 0e53372 Use weis.aeroelasticse for file reading
REVERT: c8e9954 Make tuning yaml relative to main directory
REVERT: f62653b Update InflowWind.dat templates in TuneCases/
REVERT: 3afe143 typo
REVERT: 92d6410 fix minpitch saturation bug
REVERT: a7be52a Separate below and above rated windspeeds by 30 points each

git-subtree-dir: ROSCO_toolbox
git-subtree-split: 381ae28
@ewquon
Make ROSCO use of geometry.yaml consistent with WISDEM
1ef2896 
Previously, ROSCO was expecting control.torque.VS_minspd to be the HSS speed
@ewquon
Calculate rated wspd based on rated rotor speed; fixes offset in pitc…
6aa3ebe 
…h saturation curve
@ewquon
Fix for MPI w/o any DVs -- courtesy of Nikhar Abbas
be0d175
@ptrbortolotti
Copy link
Collaborator

I knew someone was going to fix this before me! (although tests are failing now...) Thanks @ewquon! Let me know if you need help fixing the tests

gbarter
gbarter approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@gbarter gbarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are ROSCO_Toolbox changes, but I see edits to the DISCON 15MW files in WEIS. @ptrbortolotti and @nikhar-abbas Should the master 15MW repo be updated too?

@ptrbortolotti
Copy link
Collaborator

I let @nikhar-abbas answer this

@nikhar-abbas
Copy link
Collaborator

@gbarter, @ptrbortolotti,
Sorry about the confusion here. @dzalkind and I started a weis branch of the ROSCO toolbox to help things stay consistent. Eliot pulled in the Develop branch because of some ROSCO toolbox bug fixes, per my instruction, which is why we're seeing so many changes.

@ewquon, I have updated the weis branch of the ROSCO toolbox with your needed fixes - could you replace the subtree here in WEIS with ROSCO_toolbox/weis, rather than ROSCO_toolbox/develop?

On another note, I think the bug in runWEIS.py that Eliot fixed with be0d175 was my fault. This error-causing behavior is fixed and shouldn't exist once #72 is merged, but some merge conflicts might be caused. We should be careful to merge these two PRs one at a time.

@ewquon
Squashed 'ROSCO_toolbox/' changes from 381ae28..c87da84
84d812f 
c87da84 Merge commit '381ae2862ee58d9684ef5c69270eef4956ce1813' into weis
d748c9f Merge remote-tracking branch 'upstream/develop' into weis
9b123f1 Update examples to test in weis environment, working
15976f5 Merge branch 'develop' into weis
7d28a6f Get rid of annoying spectral warning
25ef7a7 Update ROSCO install dir, other setup fun stuff
52465fe Merge remote-tracking branch 'upstream/develop' into weis
3454fc0 Merge remote-tracking branch 'upstream/develop' into weis
b730428 Merge pull request WISDEM#28 from nikhar-abbas/weis
71565e1 Revert "fix minpitch saturation bug"
34b427c Update submodule to track develop branch
f504b34 remove 0.7 from flpwise damping conversion
bc8c9c3 write kappa to self
38e956e Merge branch 'weis' of https://github.com/NREL/ROSCO_toolbox into weis
096f1e9 Merge branch 'develop' into weis
cf5b43b Fix another ofTools import
67731f8 Fix ofTools import
2256b0c Move ofTools into ROSCO_toolbox
e4a1c7f Revert setup.py to exclude ROSCO build, etc.
0e53372 Use weis.aeroelasticse for file reading
c8e9954 Make tuning yaml relative to main directory
f62653b Update InflowWind.dat templates in TuneCases/
3afe143 typo
92d6410 fix minpitch saturation bug
a7be52a Separate below and above rated windspeeds by 30 points each

git-subtree-dir: ROSCO_toolbox
git-subtree-split: c87da84
@ewquon
Switch subtree to ROSCO_toolbox/weis branch
3daa620 
Merge commit '84d812f45e5d61737686e0a9ea371c8b38d899c3' into powercurve_points
@ewquon
Merge branch 'powercurve_points' of https://github.com/WISDEM/WEIS in…
a57e055 
…to powercurve_points
@ewquon
Merge branch 'powercurve_points' of https://github.com/WISDEM/WEIS in…
72bcab7 
…to powercurve_points
@ewquon
Merge branch 'powercurve_points' of https://github.com/WISDEM/WEIS in…
607db37 
…to powercurve_points
@johnjasa
Copy link
Collaborator

@ewquon do you anticipate any further changes to this or is it okay to merge it in?

@ewquon
Copy link
Contributor Author

ewquon commented Apr 23, 2021

@johnjasa I'm fine with the merge. We've already strayed far enough away from this being about powercurve points.

@johnjasa johnjasa merged commit 1c8d598 into WISDEM:powercurve_points Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbarter gbarter gbarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ewquon @ptrbortolotti @nikhar-abbas @johnjasa @gbarter