-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds primitive events controller #8
Conversation
RickWieman
commented
Oct 6, 2015
- Controller currently supports:
- Viewing all upcoming events
- Viewing a creation form (added datetimepicker and consequently momentjs dependencies)
- Storing a created event (without validation though)
- Adds first three events to landing page (not sure if sorted by starting time 😉)
- Fixes jsDelivr URLs
|
||
// Jsr310JpaConverters.class is necessary for correctly persisting e.g. LocalDateTime objects | ||
@EntityScan(basePackageClasses = {EventsApplication.class, Jsr310JpaConverters.class}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@praseodym This solved the issue of LocalDateTime.now()
not being earlier than the end date of a newly created event 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Apparently Hibernate 5 has native support, but for now this is a fine workaround.
Are the |
@praseodym Started with such a tag in the MainController, so I added one to the EventsController as well. I agree it's a bit awkward, if Mark agrees I'll remove all author tags in the codebase. |
The idea is that it's nice to see who was class' author. You'd have to add your own name when making significant changes. However, Git works fine for figuring this out as well, so feel free to remove them. |
@@ -52,6 +52,8 @@ dependencies { | |||
compile("com.zaxxer:HikariCP") | |||
|
|||
compile("com.google.guava:guava:18.0") | |||
compile 'org.webjars.bower:eonasdan-bootstrap-datetimepicker:4.17.37' | |||
compile 'org.webjars.bower:momentjs:2.10.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
net een andere syntax :')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oeps, het was laat (en ik heb lazy gekopieerd vanaf webjars)
In addition to the comments, it would be nice to have:
|
* Controller currently supports: - Viewing all events - Viewing a creation form - Storing a created event * Adds first three events to landing page * Fixes jsDelivr URLs
a35ce8c
to
e180973
Compare
2c180fd
to
7ab70a4
Compare
Not sure what else to test, moved the duplicate code reduction to #9. |
Add primitive events controller