Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

landing page post order select field throwing error when adding new LP #1904

Closed
rlambertsen opened this issue Apr 11, 2021 · 0 comments · Fixed by #1905
Closed

landing page post order select field throwing error when adding new LP #1904

rlambertsen opened this issue Apr 11, 2021 · 0 comments · Fixed by #1905
Assignees
@rlambertsen

Comments

@rlambertsen
Copy link
Collaborator

Expected Behavior

Post order field should load and work as any select field would

Actual Behavior

Select field does not show up
Fatal error: Uncaught TypeError: count(): Argument #1 ($var) must be of type Countable|array, bool given in /largo/wp-content/themes/largo/inc/wp-taxonomy-landing/functions/cftl-admin.php on line 450

Steps to Reproduce the Problem

  1. Pull down trunk branch and try to create a new landing page, note this is on a fresh install no DB data at all, zero content!!!
  2. in the Main section where post order field should be the error above is shown

Specifications

  • Version: php@7.4.16
  • Platform: MacOS using Valet to run local
  • image provided
    Screen Shot 2021-04-11 at 12 07 42 PM
@rlambertsen rlambertsen self-assigned this Apr 11, 2021
rlambertsen added a commit that referenced this issue Apr 11, 2021
@rlambertsen
#1904; cftl-admin for LP has some code checking the count() of a var …
bb3cf3e 
…is that sometimes false; need to make sure we check for that first
@rlambertsen rlambertsen mentioned this issue Apr 11, 2021
Merged
4 tasks
rlambertsen added a commit that referenced this issue Apr 11, 2021
@rlambertsen
#1904; update changelog
750a836
rlambertsen added a commit that referenced this issue Apr 11, 2021
@rlambertsen
#1904; remove duplicate code line; make the if statement better
79fd973
@joshdarby joshdarby linked a pull request Apr 11, 2021 that will close this issue
#1904 landing page post order select field throwing error when adding new lp #1905
Merged
4 tasks
rlambertsen added a commit that referenced this issue Apr 11, 2021
@rlambertsen
#1904; space
33e52a0
rlambertsen added a commit that referenced this issue Apr 11, 2021
@rlambertsen
Merge pull request #1905 from WPBuddy/#1904landing_page_post_order_se…
e47d389 
…lect_field_throwing_error_when_adding_new_LP

#1904 landing page post order select field throwing error when adding new lp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlambertsen rlambertsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1904 landing page post order select field throwing error when adding new lp WPBuddy/largo
1 participant
@rlambertsen