Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out some way to keep long sticky nav menus from wrapping #376

Closed
aschweigert opened this issue Jan 28, 2015 · 9 comments
Closed

figure out some way to keep long sticky nav menus from wrapping #376

aschweigert opened this issue Jan 28, 2015 · 9 comments
Assignees
Labels
priority: normal Must be completed before release of this version of plugin. status: in progress type: improvement
Milestone

Comments

@aschweigert
Copy link

this drives me nuts, we should probably fix the length of that menu and cut off the extra items or fade them or something so they don't wrap.

or something.

@aschweigert aschweigert added this to the 0.4.1 milestone Jan 28, 2015
@aschweigert aschweigert added type: improvement priority: normal Must be completed before release of this version of plugin. and removed type: improvement labels Jan 28, 2015
@aschweigert aschweigert modified the milestones: 0.5, 0.4.1 Feb 6, 2015
@benlk
Copy link
Collaborator

benlk commented Mar 26, 2015

Easy way is with overflow:hidden;

Another way to do it would be to sum the widths of the first-level children of the navbar ul, and if that's greater than the width of the navbar or nav-shelf, then hide from the end until the sum is less than the thing.

Or, the same approach, but create a drop-down at the end of the navbar, then add the first-level child li elements to it.

@benlk
Copy link
Collaborator

benlk commented Apr 6, 2015

Will suggests: Use JS to collapse the nav ul to the standard drop-down menu

Ryan suggests: nav menu overflow scrolls off to the side with buttons, like at http://www.americastestkitchenfeed.com/

@benlk
Copy link
Collaborator

benlk commented Apr 7, 2015

Another scrolling overflow menu, via @rdmurphy: http://theguardian.com/us.

@benlk
Copy link
Collaborator

benlk commented Jun 6, 2015

Since we decided that #703 wasn't going to be used in Largo (but it will be used in NPQ), what alternative solutions are we looking at for dealing with menus that are too long?

@benlk
Copy link
Collaborator

benlk commented Jul 1, 2015

Update: Continue bulletproofing the NPQ solution for Largo.

  • Find fix for on page load.
  • Make the collapse function call itself if it's not fully collapsed?
  • If it collapses fully on page load, (initial Flash of Unstyled Content not withstanding), then the trigger event won't need to be onscroll, but instead on a viewport resize.

@aschweigert aschweigert modified the milestones: 0.5.1, 0.5.2 Jul 13, 2015
@aschweigert aschweigert modified the milestones: 0.5.4 - Header/Navigation, 0.5.2 - Critical Bugfixes Only (Please) Jul 29, 2015
@benlk
Copy link
Collaborator

benlk commented Oct 16, 2015

When this merges, we'll need to cut it out of NPQ.

@aschweigert
Copy link
Author

needed for RNS-55

@benlk
Copy link
Collaborator

benlk commented Dec 15, 2015

Actually, once #1024 merges, we're going to have to fix NPQ anyways. And this issue won't be able to use NPQ code any more.

Gonna wait until #1024 merges.

@benlk
Copy link
Collaborator

benlk commented Dec 22, 2015

#1024 merged.

@benlk benlk closed this as completed Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: in progress type: improvement
Projects
None yet
Development

No branches or pull requests

3 participants