Pronouns

[Muirrum]

Add user-settable pronouns to the database User model. These then get concatenated onto the __str__ method of the User model in the same way as nicknames once set, except the pronouns are placed at the end inside of parentheses..

[tnurse18]

This PR contains several things besides what you mentioned in your comment. I'd recommend breaking this apart so that each change can be reviewed individually. It's typically good practice to keep PRs small and focused. The pronouns feature is also going to need a bit of work here.

[Muirrum]

Whoops, not sure how those other commits got in. Will rebase and fix

[coveralls]

Coverage increased (+0.0005%) to 93.289% when pulling d1bb519 on Muirrum:pronouns into c9891fd on WPI-LNL:master.

[jmerdich]

So, haven't seen any code review in a week so I'll step in. This looks very good, but the main remaining problem here is that people aren't able to edit their own pronouns (permissions in forms are denied by default). See image below.

This can be confusing, as developers typically give themselves admin rights, which bypass all permission checks and therefore doesn't show it as greyed-out, but you definitely want folks to be able to edit this!

You'll need to add it here, probably to both "thisisme" and "hasperm". Officers have permission to edit all users' stuff like this, nominally in case of abuse¹, but typically it's used because there's a typo or something and they're the one staring at it all the time.

lnldb/accounts/forms.py

Line 73 in a0e0cca

enable=('email', 'first_name', 'last_name', 'addr', 'wpibox', 'phone', 'class_year', 'nickname', 'carrier')

Click to see steps to reproduce this image

• python3 -m virtualenv env (first time)
• source env/Scripts/activate (Linux) OR env/Scripts/activate.bat (Windows)
• pip install -r requirements_debug.txt
• python manage.py migrate (create database and run migrations)
• python manage.py createsuperuser
• python manage.py runserver
• Login with your superuser account and use it to create a new account
• Hit "Impersonate" and then try to edit their own account.

Footnotes

1. Read: someone put an emoji in their nickname back when the database didn't support that and crashed things. ↩

[tnurse18]

I think this looks great! Thanks for working on this!