No php file functions

[khacoder]

[Implement sniff] Look for list of php file functions using WordPress.Functions.FunctionRestrictionsSniff

Rule type:

Error

Rule:

Use WordPress functionality and features first, if available.

Ref: https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features

ERROR| Verify that file system calls use the WP_Filesystem method and not PHP native functions. For a list of functions to trigger on, see Theme-Check plugin - /checks/malware.php

Theme check file covering this rule:

https://github.com/Otto42/theme-check/blob/master/checks/malware.php

Decision needed:

I have changed this from WARNING to ERROR. It is very easy to change back, but I thought it appropriate to be an ERROR. Are there any cases where use of these functions are acceptable?

To do:

• Create unit tests
• Create new sniff
• Adjust existing WPCS / PHPCS sniff and send in PR upstream.
• Add existing sniffname sniff to the ruleset.

[khacoder]

I have this sniff ready to go and will upload after final testing.

[grappler]

If the check is failing which it was in the Theme Check it should have been Required instead of a Warning so an Error is OK.

[dd32]

Just throwing a note out there - WP_Filesystem shouldn't be used in the way we see it used in themes due to these rules. It's not a replacement for file_get_contents() and the like, and is only really supposed to be used when FTP/file-editing is needed interactively.

This TRT rule makes themes effectively hide what they're doing, when it's a completely legitimate use-case for the direct filesystem calls.

[justintadlock]

^ One of the reasons I've been pushing to get file_get_contents() OK'd.

[jrfnl]

@dd32 As these things are in WPCS as well, I'd love to hear your voice in the discussion being had here: WordPress/WordPress-Coding-Standards#1265.

(Merged) PR WordPress/WordPress-Coding-Standards#1374 in response to WordPress/WordPress-Coding-Standards#943 is hopefully a step in the right direction ?

[dingo-d]

What is the status of this issue?