Extend descriptive characteristics #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
German, Spanish, French, Chinese
German, French, Spanish, Chinese
German, French, Spanish, Chinese
German, French, Spanish, (Chinese) Adds a check to the syllable counting function that raises a ValueError in case of Chinese (currently not supported).
|
@heinpa please check the tests output. also, remove the test for python3.6 from the actions |
Now supports German, French, Spanish. Appropriate tests are also extended to the new languages.
Perevalov
requested changes
Mar 26, 2024
Lithuanian, Ukrainian, Belarusian, Armenian
Lithuanian, Ukrainian, Belarusian and Armenian
Perevalov
reviewed
May 6, 2024
Perevalov
reviewed
May 6, 2024
Perevalov
reviewed
May 6, 2024
Perevalov
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.