Expand checkpoint id logging #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we would only store 2 pieces of info for local checkpoint state: 1. last committed checkpoint # 2. rollback checkpoint # This commit adds a 3rd integer: current checkpoint #. Its purpose is to avoid reusing checkpoint #s, despite possible crashes by the initializer worker.
jtfmumm
approved these changes
Nov 19, 2019
slfritchie
force-pushed
the
checkpoint-id-logging
branch
from
2c326f9
to
4649320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we would only store 2 pieces of info for local checkpoint state:
This commit adds a 3rd integer: current checkpoint #. Its purpose is to avoid reusing checkpoint #s, despite possible crashes by the initializer worker.
Fixes #3032