This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
feat: GitHub Folder #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryET
requested review from
a team,
bazaah and
ganchoradkov
and removed request for
a team and
bazaah
ffrizzo
reviewed
Jun 28, 2022
ffrizzo
suggested changes
Jun 29, 2022
ffrizzo
reviewed
Jun 29, 2022
.github/workflows/formatting.yml
Outdated
| - name: Ensure Formatting | ||
| run: | | ||
| terraform fmt -recursive -check | ||
| if [ $? -ne 0 ]; then |
There was a problem hiding this comment.
We don't need this if when we use -check terraform CLI will automatically fail. So we can keep it simple only with line 20 and remove others
There was a problem hiding this comment.
Removed those lines
Remove unnecessary if
ffrizzo
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.githuband some basic workflows