Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

feat: error logging #63

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

HarryET
Copy link
Contributor

@HarryET HarryET commented Aug 9, 2023

Description

Requested by @arein

How Has This Been Tested?

Same as from Echo/Push server

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@HarryET HarryET requested review from xav and arein August 9, 2023 18:26
@HarryET HarryET self-assigned this Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Does this already have a span for the request id?

@HarryET
Copy link
Contributor Author

HarryET commented Aug 9, 2023

We don't have that in Echo Server (something I want in Push)

Copy link
Contributor

@xav xav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are annotations on the code

@HarryET HarryET merged commit 34a7495 into WalletConnect:main Aug 23, 2023
5 of 7 checks passed
@HarryET HarryET deleted the feat/error-log branch August 23, 2023 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants