Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

feat: spans with information #66

Merged
merged 2 commits into from
Sep 7, 2023
Merged

feat: spans with information #66

merged 2 commits into from
Sep 7, 2023

Conversation

arein
Copy link
Member

@arein arein commented Aug 31, 2023

Description

Currently errors have no logs. We also have no HTTP metrics informing which route fails. This is an attempt to get HTTP path/method to inform which routes are failing.

Screenshot 2023-08-31 at 10 21 18 PM

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@github-actions
Copy link
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xav xav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@xav xav force-pushed the feat/spans branch 3 times, most recently from 08358a7 to 5578082 Compare September 7, 2023 14:23
@xav xav merged commit 7cf38e5 into main Sep 7, 2023
6 of 7 checks passed
@xav xav deleted the feat/spans branch September 7, 2023 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants