feat: implements irn_batchFetchMessages
#4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waiting on WalletConnect/walletconnect-utils#170 to be merged/release so I can bump versions in this PR |
devceline
reviewed
Apr 19, 2024
| ); | ||
| return await fetchMessages; | ||
| } catch (err) { | ||
| this.relayer.events.emit(RELAYER_EVENTS.connection_stalled); |
There was a problem hiding this comment.
Is this the only possible cause for the error?
There was a problem hiding this comment.
pretty much yes, other failures e.g. in .relayer.request are logged
Approved ✅ |
bkrem
reviewed
Apr 19, 2024
1 task
bkrem
approved these changes
Apr 22, 2024
added 2 commits
April 22, 2024 16:31
…walletconnect-monorepo into feat/batch_fetch_messages
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented
irn_batchFetchMessagesthat is called before subscribing to topics so we can sort all pending messages from the mailbox and avoid out of sync messages and improve consistency in handling when a peer comes online and receives bunch of mailbox messagesType of change
How has this been tested?
this test covers exactly this scenario https://github.com/WalletConnect/walletconnect-monorepo/blob/v2.0/packages/web3wallet/test/sign.spec.ts#L142
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.