Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added atob and btoa polyfills #4548

Merged
merged 2 commits into from
May 22, 2024
Merged

feat: added atob and btoa polyfills #4548

merged 2 commits into from
May 22, 2024

Conversation

ignaciosantise
Copy link
Contributor

@ignaciosantise ignaciosantise commented May 21, 2024 •
edited

Description

Added atob and btoa polyfills. They are needed for ethers5 and wagmi v2 to work

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • Tested it in react native sample dapps

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

ganchoradkov
ganchoradkov approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ignaciosantise ignaciosantise merged commit 022e4d4 into v2.0 May 22, 2024
9 checks passed
@ignaciosantise ignaciosantise deleted the feat/rn-polyfill branch May 22, 2024 18:03
@ganchoradkov ganchoradkov mentioned this pull request May 23, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganchoradkov ganchoradkov ganchoradkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ignaciosantise @ganchoradkov