Auth API #88
Merged
Auth API #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
reviewed
Jul 25, 2022
bkrem
reviewed
Jul 25, 2022
jakubuid
requested changes
Jul 25, 2022
auth/authentication.md
Outdated
|
|
||
| B subscribes to pairing topic from provided URI | ||
|
|
||
| B receives request and decrypts it with symKey S. |
There was a problem hiding this comment.
It's prob obvious but I'd add that symKey S is retrieved from URI.
jakubuid
reviewed
Jul 25, 2022
Co-authored-by: Bartosz Rozwarski <bartus000@gmail.com>
llbartekll
reviewed
Jul 26, 2022
llbartekll
reviewed
Jul 26, 2022
Co-authored-by: Bartosz Rozwarski <bartus000@gmail.com>
…walletconnect-specs into pedrouid/auth-api
llbartekll
reviewed
Jul 28, 2022
Comment on lines
+6
to
+15
| interface RequestParams { | ||
| chainId: string; | ||
| nonce: string; | ||
| aud?: string; | ||
| nbf?: string; | ||
| exp?: string; | ||
| statement?: string; | ||
| requestId?: string; | ||
| resources?: string[]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| interface RequestParams { | |
| chainId: string; | |
| nonce: string; | |
| aud?: string; | |
| nbf?: string; | |
| exp?: string; | |
| statement?: string; | |
| requestId?: string; | |
| resources?: string[]; | |
| } | |
| interface RequestParams { | |
| domain: string; | |
| chainId: string; | |
| nonce: string; | |
| aud: string; | |
| nbf?: string; | |
| exp?: string; | |
| statement?: string; | |
| requestId?: string; | |
| resources?: string[]; | |
| } |
There was a problem hiding this comment.
from specs:
uri in siwe is not optional so aud should not be as well
URI: {.p.aud}
domain is required I think
llbartekll
reviewed
Jul 28, 2022
| ```typescript | ||
| interface RespondParams { | ||
| topic: string; | ||
| signature: CacaoSignature; |
There was a problem hiding this comment.
I think signature may not be enough as requester do not know the whole payload and type.
could we return Cacao instead?
6 tasks
bkrem
pushed a commit
that referenced
this pull request
May 23, 2024
chris13524
pushed a commit
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft to Auth API spec
Related to WalletConnect/walletconnect-docs#253