Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused demo code and convert to typescript #6

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

knewkirk
Copy link
Contributor

Using the demo app inside this repo instead of creating a separate repo to test out features. Looked like that's where this was headed originally, might as well use it.

Doing some housekeeping to get the demo app in a good spot to support the updated requirements:

  • convert to typescript because it's a good idea
  • remove some unused/unreferenced code because it's messy

@wchan2
Copy link
Contributor

wchan2 commented Oct 12, 2022

I also made the test_page as a super simple test for the initial client auth integration. I'll leave it up to you and the team whether you guys find that kind of simplicity valuable. If not, we can probably remove that too.

@knewkirk
Copy link
Contributor Author

Ah yeah I saw that - might come in handy later when we start testing out packaging stuff, might as well leave it in for the time being, might come back to it later. Thanks for the heads up! I think right now I'll keep with the react app just to more closely mirror sdk usage for a potential customer.

fyi I think I'll also just keep all my work on a branch and then put up a PR to master once things are working and in a good spot, don't want to spam y'all with PRs, and probably don't need eyes on everything.

@knewkirk knewkirk closed this Oct 12, 2022
@knewkirk knewkirk reopened this Oct 12, 2022
@knewkirk knewkirk merged commit f8bb5a7 into master Oct 12, 2022
@mjmayank mjmayank deleted the kyle-demo-updates branch December 1, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants